Re: [PATCH] NFS: Fix kbuild errors due to missing symbols

[Anna Schumaker <bjschuma@netapp.com>]

On 11/15/2013 06:16 PM, Trond Myklebust wrote:
> On Fri, 2013-11-15 at 17:30 -0500, Anna Schumaker wrote:
>> My recent patch 644aa303: "NFS: Enabling v4.2 should not recompile nfsd
>> and lockd" caused build errors when CONFIG_NFS_USE_LEGACY_DNS=y and when
>> CONFIG_NFS_V4=n.  This patch fixes those errors.
>>
> 
> Wait... 
> 
>         config NFS_USE_LEGACY_DNS
>                 bool "Use the legacy NFS DNS resolver"
>                 depends on NFS_V4
>                 help
>                   The kernel now provides a method for translating a host name into an
>                   IP address.  Select Y here if you would rather use your own DNS
>                   resolver script.
>         
>                   If unsure, say N
>         
>         config NFS_USE_KERNEL_DNS
>                 bool
>                 depends on NFS_V4 && !NFS_USE_LEGACY_DNS
>                 select DNS_RESOLVER
>                 default y
> 
> How can that result in NFS_V4=n && NFS_USE_LEGACY_DNS=y?
> 

It's a poorly phrased commit message, actually.  I meant that just setting CONFIG_NFS_USE_LEGACY_DNS=y causes build problems, and then setting CONFIG_NFS_V4=n causes a different set of errors.