Re: [Xenomai] [Xenomai-git] Jan Kiszka : switchtest: Account for invalid last_switch.from field

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2013-11-18 19:03, Gilles Chanteperdrix wrote:
> On 11/18/2013 06:57 PM, Jan Kiszka wrote:
>> On 2013-11-18 18:42, Gilles Chanteperdrix wrote:
>>> On 11/18/2013 05:58 PM, Jan Kiszka wrote:
>>>> Bailing out from rtswitch_pend_rt remains correct and necessary (with
>>>> the new RTDM semantics): rtdm_task_destroy will now kick us out of the
>>>> rtdm_even_wait, and that at a time where no switch happened yet.
>>>
>>> So, you also have to check rtswitch_to_rt return value, and return in
>>> that case as well.
>>
>> We could, but rtdm_task_should_stop already makes sure that we don't
>> spin endlessly.
> 
> Then why do not just put rtdm_task_should_stop at the beginning of the
> loop to catch both the case where rtswitch_pend_rt or rtswitch_to_rt
> were interrupted?
> 

Sure, will write the patch accordingly.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux