From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <528A58B0.7070400@siemens.com> Date: Mon, 18 Nov 2013 19:13:04 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <528A156C.1070501@xenomai.org> <528A21A9.9050502@siemens.com> <528A2486.4030606@xenomai.org> <528A2567.2000105@siemens.com> <528A27AF.3060608@xenomai.org> <528A2BB3.9040902@siemens.com> <528A2F96.7080302@xenomai.org> <528A3918.4000902@siemens.com> <528A3CEB.80909@xenomai.org> <528A446C.5060409@siemens.com> <528A4737.8040607@siemens.com> <528A5170.4070609@xenomai.org> <528A54F5.4000609@siemens.com> <528A5678.2000908@xenomai.org> In-Reply-To: <528A5678.2000908@xenomai.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Xenomai] [Xenomai-git] Jan Kiszka : switchtest: Account for invalid last_switch.from field List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gilles Chanteperdrix Cc: xenomai@xenomai.org On 2013-11-18 19:03, Gilles Chanteperdrix wrote: > On 11/18/2013 06:57 PM, Jan Kiszka wrote: >> On 2013-11-18 18:42, Gilles Chanteperdrix wrote: >>> On 11/18/2013 05:58 PM, Jan Kiszka wrote: >>>> Bailing out from rtswitch_pend_rt remains correct and necessary (with >>>> the new RTDM semantics): rtdm_task_destroy will now kick us out of the >>>> rtdm_even_wait, and that at a time where no switch happened yet. >>> >>> So, you also have to check rtswitch_to_rt return value, and return in >>> that case as well. >> >> We could, but rtdm_task_should_stop already makes sure that we don't >> spin endlessly. > > Then why do not just put rtdm_task_should_stop at the beginning of the > loop to catch both the case where rtswitch_pend_rt or rtswitch_to_rt > were interrupted? > Sure, will write the patch accordingly. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux