From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v3] can: fix sja1000 pre_irq/post_irq handling Date: Mon, 18 Nov 2013 20:38:56 +0100 Message-ID: <528A6CD0.4090507@grandegger.com> References: <528A0F9A.6070305@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ngcobalt02.manitu.net ([217.11.48.102]:59350 "EHLO ngcobalt02.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420Ab3KRTi6 (ORCPT ); Mon, 18 Nov 2013 14:38:58 -0500 In-Reply-To: <528A0F9A.6070305@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp , "linux-can@vger.kernel.org" On 11/18/2013 02:01 PM, Oliver Hartkopp wrote: > The SJA1000 driver provides optional function pointers to handle specific > hardware setups at interrupt time. > > This patch fixes the issue that the sja1000_interrupt() function may have > returned IRQ_NONE without processing the post_irq function. Additionally > an introduced and documented return value from the pre_irq function is > checked to skip the entire interrupt handling on pre_irq function errors. > > Reported-by: Wolfgang Grandegger > Signed-off-by: Oliver Hartkopp Acked-by: Wolfgang Grandegger Thanks, Wolfgang.