From: "H. Peter Anvin" <hpa@zytor.com>
To: Elena Ufimtseva <ufimtseva@gmail.com>, xen-devel@lists.xenproject.org
Cc: konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
david.vrabel@citrix.com, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, akpm@linux-foundation.org,
tangchen@cn.fujitsu.com, wency@cn.fujitsu.com,
ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
mukesh.rathor@oracle.com, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 1/2] xen: vnuma support for PV guests running as domU
Date: Mon, 18 Nov 2013 13:14:03 -0800 [thread overview]
Message-ID: <528A831B.8020602@zytor.com> (raw)
In-Reply-To: <1384806350-12651-2-git-send-email-ufimtseva@gmail.com>
On 11/18/2013 12:25 PM, Elena Ufimtseva wrote:
> +/* Checks if hypercall is supported */
> +bool xen_vnuma_supported()
This isn't C++...
http://lwn.net/Articles/487493/
There are several more things in this patchset that get flagged by
checkpatch, but apparently this rather common (and rather serious)
problem is still not being detected, even through a patch was submitted
almost two years ago:
https://lkml.org/lkml/2012/3/16/510
-hpa
next prev parent reply other threads:[~2013-11-18 21:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:25 [PATCH v2 0/2] xen: vnuma introduction for pv guest Elena Ufimtseva
2013-11-18 20:25 ` [PATCH v2 1/2] xen: vnuma support for PV guests running as domU Elena Ufimtseva
2013-11-18 21:14 ` H. Peter Anvin [this message]
2013-11-18 21:28 ` Elena Ufimtseva
2013-11-18 21:28 ` Elena Ufimtseva
2013-11-18 22:13 ` Joe Perches
2013-11-18 22:13 ` Joe Perches
2013-11-18 21:14 ` H. Peter Anvin
2013-11-19 7:15 ` Dario Faggioli
2013-11-19 7:15 ` [Xen-devel] " Dario Faggioli
2013-11-18 20:25 ` Elena Ufimtseva
2013-11-18 20:25 ` [PATCH v2 2/2] xen: enable vnuma for PV guest Elena Ufimtseva
2013-11-18 20:25 ` Elena Ufimtseva
2013-11-19 15:38 ` [PATCH v2 0/2] xen: vnuma introduction for pv guest Konrad Rzeszutek Wilk
2013-11-19 15:38 ` Konrad Rzeszutek Wilk
2013-11-19 18:29 ` Dario Faggioli
2013-11-19 18:29 ` [Xen-devel] " Dario Faggioli
2013-12-04 0:35 ` Elena Ufimtseva
2013-12-04 6:20 ` Elena Ufimtseva
2013-12-05 1:13 ` Dario Faggioli
2013-12-05 1:13 ` [Xen-devel] " Dario Faggioli
2013-12-20 7:39 ` Elena Ufimtseva
2013-12-20 7:39 ` [Xen-devel] " Elena Ufimtseva
2013-12-20 7:48 ` Elena Ufimtseva
2013-12-20 15:38 ` Dario Faggioli
2013-12-20 15:38 ` Dario Faggioli
2013-12-20 7:48 ` Elena Ufimtseva
2013-12-04 6:20 ` Elena Ufimtseva
2013-12-04 0:35 ` Elena Ufimtseva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A831B.8020602@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=ufimtseva@gmail.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.