From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH] ARM: OMAP2+: Fix undefined reference to set_cntfreq Date: Mon, 18 Nov 2013 19:04:40 -0500 Message-ID: <528AAB18.7040105@ti.com> References: <20131118215855.GW10317@atomide.com> <528A9E8C.9040903@ti.com> <20131118232145.GX10317@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:51477 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307Ab3KSAFN (ORCPT ); Mon, 18 Nov 2013 19:05:13 -0500 In-Reply-To: <20131118232145.GX10317@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org On Monday 18 November 2013 06:21 PM, Tony Lindgren wrote: > * Santosh Shilimkar [131118 15:11]: >> On Monday 18 November 2013 04:58 PM, Tony Lindgren wrote: >>> If CONFIG_SOC_HAS_REALTIME_COUNTER is not selected for omap5 >>> or dra7xx, we can get the following error: >>> >>> arch/arm/mach-omap2/built-in.o: In function `omap4_secondary_init': >>> :(.text+0x7ab0): undefined reference to `set_cntfreq' >>> >>> Fix the issue by not trying to initalize the realtime counter >>> unles CONFIG_SOC_HAS_REALTIME_COUNTER is selected. >>> >>> Signed-off-by: Tony Lindgren >>> >> How about a dummy inline function of set_cntfreq() ? >> Having #ifdef in middle of the code looks pretty ugly. > > Sure, here's an updated version. > Thanks for quick spin. > > > From: Tony Lindgren > Date: Mon, 18 Nov 2013 13:56:48 -0800 > Subject: [PATCH] ARM: OMAP2+: Fix undefined reference to set_cntfreq > > If CONFIG_SOC_HAS_REALTIME_COUNTER is not selected for omap5 > or dra7xx, we can get the following error: > > arch/arm/mach-omap2/built-in.o: In function `omap4_secondary_init': > :(.text+0x7ab0): undefined reference to `set_cntfreq' > > Fix the issue by not trying to initalize the realtime counter > unles CONFIG_SOC_HAS_REALTIME_COUNTER is selected. > > Signed-off-by: Tony Lindgren > Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Mon, 18 Nov 2013 19:04:40 -0500 Subject: [PATCH] ARM: OMAP2+: Fix undefined reference to set_cntfreq In-Reply-To: <20131118232145.GX10317@atomide.com> References: <20131118215855.GW10317@atomide.com> <528A9E8C.9040903@ti.com> <20131118232145.GX10317@atomide.com> Message-ID: <528AAB18.7040105@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 18 November 2013 06:21 PM, Tony Lindgren wrote: > * Santosh Shilimkar [131118 15:11]: >> On Monday 18 November 2013 04:58 PM, Tony Lindgren wrote: >>> If CONFIG_SOC_HAS_REALTIME_COUNTER is not selected for omap5 >>> or dra7xx, we can get the following error: >>> >>> arch/arm/mach-omap2/built-in.o: In function `omap4_secondary_init': >>> :(.text+0x7ab0): undefined reference to `set_cntfreq' >>> >>> Fix the issue by not trying to initalize the realtime counter >>> unles CONFIG_SOC_HAS_REALTIME_COUNTER is selected. >>> >>> Signed-off-by: Tony Lindgren >>> >> How about a dummy inline function of set_cntfreq() ? >> Having #ifdef in middle of the code looks pretty ugly. > > Sure, here's an updated version. > Thanks for quick spin. > > > From: Tony Lindgren > Date: Mon, 18 Nov 2013 13:56:48 -0800 > Subject: [PATCH] ARM: OMAP2+: Fix undefined reference to set_cntfreq > > If CONFIG_SOC_HAS_REALTIME_COUNTER is not selected for omap5 > or dra7xx, we can get the following error: > > arch/arm/mach-omap2/built-in.o: In function `omap4_secondary_init': > :(.text+0x7ab0): undefined reference to `set_cntfreq' > > Fix the issue by not trying to initalize the realtime counter > unles CONFIG_SOC_HAS_REALTIME_COUNTER is selected. > > Signed-off-by: Tony Lindgren > Acked-by: Santosh Shilimkar