From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH RFC v2] pvh: clearly specify used parameters in vcpu_guest_context Date: Tue, 19 Nov 2013 10:34:11 +0000 Message-ID: <528B3EA3.9090008@eu.citrix.com> References: <1384798711-4255-1-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ViidM-0000F8-Pr for xen-devel@lists.xenproject.org; Tue, 19 Nov 2013 10:34:17 +0000 In-Reply-To: <1384798711-4255-1-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Keir Fraser , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMTEvMTgvMjAxMyAwNjoxOCBQTSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+IFRoZSBhaW0g b2YgdGhpcyBwYXRjaCBpcyB0byBkZWZpbmUgYSBzdGFibGUgd2F5IGluIHdoaWNoIFBWSCBpcwo+ IGdvaW5nIHRvIGRvIEFQIGJyaW5ndXAuCj4KPiBTaW5jZSB3ZSBhcmUgcnVubmluZyBpbnNpZGUg b2YgYSBIVk0gY29udGFpbmVyLCBQVkggc2hvdWxkIG9ubHkgbmVlZAo+IHRvIHNldCBmbGFncywg Y3IzIGFuZCB1c2VyX3JlZ3MgaW4gb3JkZXIgdG8gYnJpbmcgdXAgYSB2Q1BVLCB0aGUgcmVzdAo+ IGNhbiBiZSBzZXQgb25jZSB0aGUgdkNQVSBpcyBzdGFydGVkIHVzaW5nIHRoZSBiYXJlIG1ldGFs IG1ldGhvZHMuCj4gQWRkaXRpb25hbGx5LCB0aGUgZ3Vlc3QgY2FuIGFsc28gc2V0IGNyMCBhbmQg Y3I0LCBhbmQgdGhvc2UgdmFsdWVzCj4gd2lsbCBiZSBhcHBlbmRlZCB0byB0aGUgZGVmYXVsdCB2 YWx1ZXMgc2V0IGJ5IFhlbi4KPgo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJv Z2VyLnBhdUBjaXRyaXguY29tPgo+IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGV1 LmNpdHJpeC5jb20+Cj4gQ2M6IE11a2VzaCBSYXRob3IgPG11a2VzaC5yYXRob3JAb3JhY2xlLmNv bT4KPiBDYzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IENjOiBUaW0gRGVlZ2Fu IDx0aW1AeGVuLm9yZz4KPiBDYzogS2VpciBGcmFzZXIgPGtlaXJAeGVuLm9yZz4KPiAtLS0KPiAg IHhlbi9hcmNoL3g4Ni9kb21haW4uYyAgICAgICAgICAgICB8ICAgMjQgKysrKysrKysrKysrKysr Ky0tLS0tLS0tCj4gICB4ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyAgICAgICAgfCAgICA2ICst LS0tLQo+ICAgeGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vaHZtLmggICAgIHwgICAgNiArKystLS0K PiAgIHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni94ZW4uaCB8ICAgIDggKysrKy0tLS0KPiAg IDQgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2RvbWFpbi5jIGIveGVuL2FyY2gveDg2L2RvbWFpbi5j Cj4gaW5kZXggYTM4NjhmOS4uNTEzMTFmYyAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvZG9t YWluLmMKPiArKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKPiBAQCAtNTEsNiArNTEsNyBAQAo+ ICAgI2luY2x1ZGUgPGFzbS9maXhtYXAuaD4KPiAgICNpbmNsdWRlIDxhc20vaHZtL2h2bS5oPgo+ ICAgI2luY2x1ZGUgPGFzbS9odm0vc3VwcG9ydC5oPgo+ICsjaW5jbHVkZSA8YXNtL2h2bS9uZXN0 ZWRodm0uaD4KPiAgICNpbmNsdWRlIDxhc20vZGVidWdyZWcuaD4KPiAgICNpbmNsdWRlIDxhc20v bXNyLmg+Cj4gICAjaW5jbHVkZSA8YXNtL3RyYXBzLmg+Cj4gQEAgLTcwNCw5ICs3MDUsMTMgQEAg aW50IGFyY2hfc2V0X2luZm9fZ3Vlc3QoCj4gICAgICAgICAgIC8qIFBWSCAzMmJpdGZpeG1lICov Cj4gICAgICAgICAgIEFTU0VSVCghY29tcGF0KTsKPgo+IC0gICAgICAgIGlmICggYyhjdHJscmVn WzFdKSB8fCBjKGxkdF9iYXNlKSB8fCBjKGxkdF9lbnRzKSB8fAo+ICsgICAgICAgIGlmICggKGMo Y3RybHJlZ1swXSkgJiBIVk1fQ1IwX0dVRVNUX1JFU0VSVkVEX0JJVFMpIHx8Cj4gKyAgICAgICAg ICAgICAoYyhjdHJscmVnWzRdKSAmIEhWTV9DUjRfR1VFU1RfUkVTRVJWRURfQklUUyh2KSkgfHwK Ckdvb2QgaWRlYS4gOi0pCgo+ICsgICAgICAgICAgICAgYyhjdHJscmVnWzFdKSB8fCBjKGN0cmxy ZWdbMl0pIHx8IGMoY3RybHJlZ1s1XSkgfHwKPiArICAgICAgICAgICAgIGMoY3RybHJlZ1s2XSkg fHwgYyhjdHJscmVnWzddKSB8fCBjKGxkdF9iYXNlKSB8fCBjKGxkdF9lbnRzKSB8fAo+ICAgICAg ICAgICAgICAgIGModXNlcl9yZWdzLmNzKSB8fCBjKHVzZXJfcmVncy5zcykgfHwgYyh1c2VyX3Jl Z3MuZXMpIHx8Cj4gICAgICAgICAgICAgICAgYyh1c2VyX3JlZ3MuZHMpIHx8IGModXNlcl9yZWdz LmZzKSB8fCBjKHVzZXJfcmVncy5ncykgfHwKPiArICAgICAgICAgICAgIGMoa2VybmVsX3NzKSB8 fCBjKGtlcm5lbF9zcCkgfHwgYy5uYXQtPmdzX2Jhc2Vfa2VybmVsIHx8Cj4gICAgICAgICAgICAg ICAgYy5uYXQtPmdkdF9lbnRzIHx8IGMubmF0LT5mc19iYXNlIHx8IGMubmF0LT5nc19iYXNlX3Vz ZXIgKQo+ICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gICAgICAgfQo+IEBAIC03NDUs MTcgKzc1MCwyMCBAQCBpbnQgYXJjaF9zZXRfaW5mb19ndWVzdCgKPgo+ICAgICAgIGlmICggaGFz X2h2bV9jb250YWluZXJfdmNwdSh2KSApCj4gICAgICAgewo+IC0gICAgICAgIC8qCj4gLSAgICAg ICAgICogTkI6IFRGX2tlcm5lbF9tb2RlIGlzIHNldCB1bmNvbmRpdGlvbmFsbHkgZm9yIEhWTSBn dWVzdHMsCj4gLSAgICAgICAgICogc28gd2UgYWx3YXlzIHVzZSB0aGUgZ3NfYmFzZV9rZXJuZWwg aGVyZS4gSWYgd2UgY2hhbmdlIHRoaXMKPiAtICAgICAgICAgKiBmdW5jdGlvbiB0byBpbWl0YXRl IHRoZSBQViBmdW5jdGlvbmFsaXR5LCB3ZSdsbCBuZWVkIHRvCj4gLSAgICAgICAgICogbWFrZSBp dCBwYXkgYXR0ZW50aW9uIHRvIHRoZSBrZXJuZWwgYml0Lgo+IC0gICAgICAgICAqLwo+IC0gICAg ICAgIGh2bV9zZXRfaW5mb19ndWVzdCh2LCBjb21wYXQgPyAwIDogYy5uYXQtPmdzX2Jhc2Vfa2Vy bmVsKTsKCkkgdGhpbmsgd2Ugc3RpbGwgbmVlZCB0byBjYWxsIGh2bV9zZXRfaW5mb19ndWVzdCgp IGhlcmUgLS0gdGhlcmUgaXMgCm90aGVyIHN0dWZmIGJlaW5nIHNldCB1cCwgYW5kIGl0IHdhcyBj YWxsZWQgKHdpdGhvdXQgdGhlIGV4dHJhIGFyZ3VtZW50IApmb3IgZ3NfYmFzZV9rZXJuZWwpIGJl Zm9yZSB0aGUgUFZIIHBhdGNoIHNlcmllcyB3ZW50IGluLgoKKFNlZSBjL3MgMzViMWUwNy4pCgo+ Cj4gICAgICAgICAgIGlmICggaXNfaHZtX3ZjcHUodikgfHwgdi0+aXNfaW5pdGlhbGlzZWQgKQo+ ICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4KPiArICAgICAgICBpZiAoIGMubmF0LT5jdHJscmVn WzBdICkgewo+ICsgICAgICAgICAgICB2LT5hcmNoLmh2bV92Y3B1Lmd1ZXN0X2NyWzBdIHw9IGMu bmF0LT5jdHJscmVnWzBdOwo+ICsgICAgICAgICAgICBodm1fdXBkYXRlX2d1ZXN0X2NyKHYsIDAp Owo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgaWYgKCBjLm5hdC0+Y3RybHJlZ1s0XSApIHsK PiArICAgICAgICAgICAgdi0+YXJjaC5odm1fdmNwdS5ndWVzdF9jcls0XSB8PSBjLm5hdC0+Y3Ry bHJlZ1s0XTsKPiArICAgICAgICAgICAgaHZtX3VwZGF0ZV9ndWVzdF9jcih2LCA0KTsKPiArICAg ICAgICB9CgpJIHRob3VnaHQgdGhlIGlkZWEgd2FzIHRoYXQgaGUgd291bGQgc2V0IGNyMCwgY3Iz LCBhbmQgY3I0IGZvciBhbGwgSFZNIApndWVzdHMsIHJhdGhlciB0aGFuIHNwZWNpYWwtY2FzaW5n IFBWSCBndWVzdHM/CgogIC1HZW9yZ2UKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=