From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/3] arinc: Add cpu-pool support to
	scheduler.
Date: Tue, 19 Nov 2013 11:33:57 +0000
Message-ID: <528B4CA5.9020204@citrix.com>
References: <1384805814-3597-1-git-send-email-nate.studer@dornerworks.com>
	<1384805814-3597-3-git-send-email-nate.studer@dornerworks.com>
	<528B3DBA.9020802@citrix.com> <528B4919.3030404@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <528B4919.3030404@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Simon Martin <smartin@milliways.cl>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, xen-devel@lists.xen.org, Nathan Studer <nate.studer@dornerworks.com>
List-Id: xen-devel@lists.xenproject.org

On 19/11/2013 11:18, George Dunlap wrote:
> On 11/19/2013 10:30 AM, Andrew Cooper wrote:
>> On 18/11/2013 20:16, Nathan Studer wrote:
>>> @@ -450,7 +454,7 @@ a653sched_alloc_pdata(const struct scheduler
>>> *ops, int cpu)
>>>   static void
>>>   a653sched_free_pdata(const struct scheduler *ops, void *pcpu, int
>>> cpu)
>>>   {
>>> -    /* nop */
>>> +    /* NOP */
>>
>> This change seems a little pointless.
>
> So is this criticism.  If the maintainer thinks the comment would look
> better upper-case, he can change it.
>
>  -George

Sorry - I did not intend for this to come across as a criticism.  It is
of course the maintainers prerogative as to which case he likes his
comments in.

It is also a seemingly random and unrelated change to the purpose of the
patch, and therefore open to query under our guidelines for patches.

http://wiki.xen.org/wiki/Submitting_Xen_Patches#Break_down_your_patches

~Andrew