From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sourav Poddar Subject: Re: [PATCH] spi/qspi: cleanup qspi remova path and error check. Date: Tue, 19 Nov 2013 17:20:57 +0530 Message-ID: <528B50A1.1080609@ti.com> References: <1384858703-30938-1-git-send-email-sourav.poddar@ti.com> <20131119113125.GZ2674@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: To: Mark Brown Return-path: In-Reply-To: <20131119113125.GZ2674-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Tuesday 19 November 2013 05:01 PM, Mark Brown wrote: > On Tue, Nov 19, 2013 at 04:28:23PM +0530, Sourav Poddar wrote: >> There is a bug in qspi removal path, as a result of which >> qspi cannot be removed when used as a module. The patch >> solves the bug and qspi can be removed cleanly. > What is the bug? The important bit of information is what's actually > being changed. > pm_runtime api is not used to properly disable the PM part. spi_unregister_master(qspi->master) shows a NULL pointer dereference. >> Also align the runtime error path check through out the code. Ok. > This should be split out. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html