From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vik2s-0006yO-7d for qemu-devel@nongnu.org; Tue, 19 Nov 2013 07:04:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vik2f-0002rj-En for qemu-devel@nongnu.org; Tue, 19 Nov 2013 07:04:42 -0500 Received: from mail-pd0-f182.google.com ([209.85.192.182]:62383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vik2f-0002rL-9t for qemu-devel@nongnu.org; Tue, 19 Nov 2013 07:04:29 -0500 Received: by mail-pd0-f182.google.com with SMTP id v10so2443544pde.13 for ; Tue, 19 Nov 2013 04:04:28 -0800 (PST) Message-ID: <528B53C2.1090000@ozlabs.ru> Date: Tue, 19 Nov 2013 23:04:18 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1384835335-15116-1-git-send-email-aik@ozlabs.ru> <1384835335-15116-3-git-send-email-aik@ozlabs.ru> <33A8A9EF-36E8-45F1-9B42-43D5934E0E8C@suse.de> <45062234-2073-4B7B-A748-B12EF9E337B7@suse.de> In-Reply-To: <45062234-2073-4B7B-A748-B12EF9E337B7@suse.de> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc , QEMU Developers On 11/19/2013 09:43 PM, Alexander Graf wrote: > > On 19.11.2013, at 11:36, Alexander Graf wrote: > >> >> On 19.11.2013, at 05:28, Alexey Kardashevskiy wrote: >> >>> This adds very basic handlers for ibm,get-system-parameter and >>> ibm,set-system-parameter RTAS calls. >>> >>> The only parameter handled at the moment is >>> "platform-processor-diagnostics-run-mode" which is always disabled and >>> does not support changing. This is expected to make >>> "ppc64_cpu --run-mode=1" happy. >>> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> Changes: >>> v3: >>> * reworked all return codes (in a separate patch) >>> >>> v2: >>> * addressed comments from Alex Graf >>> --- >>> hw/ppc/spapr_rtas.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ >>> include/hw/ppc/spapr.h | 2 ++ >>> 2 files changed, 49 insertions(+) >>> >>> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c >>> index f9897a5..d7b1f1d 100644 >>> --- a/hw/ppc/spapr_rtas.c >>> +++ b/hw/ppc/spapr_rtas.c >>> @@ -224,6 +224,49 @@ static void rtas_stop_self(PowerPCCPU *cpu, sPAPREnvironment *spapr, >>> env->msr = 0; >>> } >>> >>> +#define DIAGNOSTICS_RUN_MODE 42 >>> + >>> +static void rtas_ibm_get_system_parameter(PowerPCCPU *cpu, >>> + sPAPREnvironment *spapr, >>> + uint32_t token, uint32_t nargs, >>> + target_ulong args, >>> + uint32_t nret, target_ulong rets) >>> +{ >>> + target_ulong papameter = rtas_ld(args, 0); >> >> Sorry, saw that one too late. What is a papameter? Is it related to the pope? :) > > I changed it locally to "parameter" and applied the patch to ppc-next. Thanks a lot. Oh. "git citool" does not spell check the code :) Thanks! -- Alexey