Re: [Qemu-devel] [PATCH 1/2] block: Enable BDRV_O_SNAPSHOT with driver-specific options

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On 11/19/2013 08:37 AM, Kevin Wolf wrote:
> In the case of snapshot=on, don't rely on the backing file path in the
> temporary image any more, but override the backing file with the given
> set of options. This way, block drivers that don't use a file name can
> be accessed with snapshot=on, for example:
> 
>     -drive file.driver=nbd,file.host=localhost,snapshot=on
> 
> Which becomes internally something like:
> 
>     file.filename=/tmp/vl.AWQZCu,backing.file.driver=nbd,backing.file.host=localhost

[libvirt isn't using snapshot=on, but that doesn't affect the utility of
this patch]

> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c | 49 +++++++++++++++++++++++--------------------------
>  1 file changed, 23 insertions(+), 26 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]