From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <528B8F1C.3090506@ti.com> Date: Tue, 19 Nov 2013 18:17:32 +0200 From: Grygorii Strashko MIME-Version: 1.0 To: Guenter Roeck , Ivan Khoronzhuk , Santosh Shilimkar , Wim Van Sebroeck , Sekhar Nori , , CC: Grant Likely , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Kumar Gala , Ian Campbell , , Subject: Re: [PATCH 1/6] watchdog: davinci: change driver to use WDT core References: <1384795139-19466-1-git-send-email-ivan.khoronzhuk@ti.com> <1384795139-19466-2-git-send-email-ivan.khoronzhuk@ti.com> <528AF349.9070902@roeck-us.net> In-Reply-To: <528AF349.9070902@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit List-ID: On 11/19/2013 07:12 AM, Guenter Roeck wrote: > On 11/18/2013 09:18 AM, Ivan Khoronzhuk wrote: >> To reduce code duplicate and increase code readability use WDT core >> code to handle WDT interface. >> >> Remove io_lock as the WDT core uses mutex to lock each wdt device. >> Remove wdt_state as the WDT core track state with its own variable. >> >> The watchdog_init_timeout() can read timeout value from timeout-sec >> property if the passed value is out of bounds. The heartbeat is >> initialized in next way. If heartbeat is not set thought module >> parameter, try to read it's value from WDT node timeout-sec property. >> If node has no one, use default value. >> >> The heartbeat is hold in wdd->timeout by WDT core, so use it in >> order to set timeout period. >> >> Signed-off-by: Ivan Khoronzhuk >> Acked-by: Santosh Shilimkar >> --- >> drivers/watchdog/Kconfig | 2 + >> drivers/watchdog/davinci_wdt.c | 152 >> ++++++++++------------------------------ >> 2 files changed, 39 insertions(+), 115 deletions(-) >> >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index d1d53f3..d7db13d 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -271,6 +271,8 @@ config IOP_WATCHDOG >> config DAVINCI_WATCHDOG >> tristate "DaVinci watchdog" >> depends on ARCH_DAVINCI >> + select WATCHDOG_CORE >> + select WATCHDOG_NOWAYOUT > > Is this mandatory, ie is it correct that the watchdog can not be stopped > once started ? > > Assuming it is, Yes, it is. Davinci WDT can't be stopped and once it's expired - it can be rearmed only after hardware reset. > > Reviewed-by: Guenter Roeck > Thanks a lot for your review. Regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Tue, 19 Nov 2013 18:17:32 +0200 Subject: [PATCH 1/6] watchdog: davinci: change driver to use WDT core In-Reply-To: <528AF349.9070902@roeck-us.net> References: <1384795139-19466-1-git-send-email-ivan.khoronzhuk@ti.com> <1384795139-19466-2-git-send-email-ivan.khoronzhuk@ti.com> <528AF349.9070902@roeck-us.net> Message-ID: <528B8F1C.3090506@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/19/2013 07:12 AM, Guenter Roeck wrote: > On 11/18/2013 09:18 AM, Ivan Khoronzhuk wrote: >> To reduce code duplicate and increase code readability use WDT core >> code to handle WDT interface. >> >> Remove io_lock as the WDT core uses mutex to lock each wdt device. >> Remove wdt_state as the WDT core track state with its own variable. >> >> The watchdog_init_timeout() can read timeout value from timeout-sec >> property if the passed value is out of bounds. The heartbeat is >> initialized in next way. If heartbeat is not set thought module >> parameter, try to read it's value from WDT node timeout-sec property. >> If node has no one, use default value. >> >> The heartbeat is hold in wdd->timeout by WDT core, so use it in >> order to set timeout period. >> >> Signed-off-by: Ivan Khoronzhuk >> Acked-by: Santosh Shilimkar >> --- >> drivers/watchdog/Kconfig | 2 + >> drivers/watchdog/davinci_wdt.c | 152 >> ++++++++++------------------------------ >> 2 files changed, 39 insertions(+), 115 deletions(-) >> >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index d1d53f3..d7db13d 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -271,6 +271,8 @@ config IOP_WATCHDOG >> config DAVINCI_WATCHDOG >> tristate "DaVinci watchdog" >> depends on ARCH_DAVINCI >> + select WATCHDOG_CORE >> + select WATCHDOG_NOWAYOUT > > Is this mandatory, ie is it correct that the watchdog can not be stopped > once started ? > > Assuming it is, Yes, it is. Davinci WDT can't be stopped and once it's expired - it can be rearmed only after hardware reset. > > Reviewed-by: Guenter Roeck > Thanks a lot for your review. Regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH 1/6] watchdog: davinci: change driver to use WDT core Date: Tue, 19 Nov 2013 18:17:32 +0200 Message-ID: <528B8F1C.3090506@ti.com> References: <1384795139-19466-1-git-send-email-ivan.khoronzhuk@ti.com> <1384795139-19466-2-git-send-email-ivan.khoronzhuk@ti.com> <528AF349.9070902@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <528AF349.9070902@roeck-us.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Guenter Roeck , Ivan Khoronzhuk , Santosh Shilimkar , Wim Van Sebroeck , Sekhar Nori , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org Cc: Mark Rutland , Pawel Moll , Stephen Warren , Ian Campbell , Kumar Gala , Rob Herring , linux-kernel@vger.kernel.org, Grant Likely , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 11/19/2013 07:12 AM, Guenter Roeck wrote: > On 11/18/2013 09:18 AM, Ivan Khoronzhuk wrote: >> To reduce code duplicate and increase code readability use WDT core >> code to handle WDT interface. >> >> Remove io_lock as the WDT core uses mutex to lock each wdt device. >> Remove wdt_state as the WDT core track state with its own variable. >> >> The watchdog_init_timeout() can read timeout value from timeout-sec >> property if the passed value is out of bounds. The heartbeat is >> initialized in next way. If heartbeat is not set thought module >> parameter, try to read it's value from WDT node timeout-sec property. >> If node has no one, use default value. >> >> The heartbeat is hold in wdd->timeout by WDT core, so use it in >> order to set timeout period. >> >> Signed-off-by: Ivan Khoronzhuk >> Acked-by: Santosh Shilimkar >> --- >> drivers/watchdog/Kconfig | 2 + >> drivers/watchdog/davinci_wdt.c | 152 >> ++++++++++------------------------------ >> 2 files changed, 39 insertions(+), 115 deletions(-) >> >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index d1d53f3..d7db13d 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -271,6 +271,8 @@ config IOP_WATCHDOG >> config DAVINCI_WATCHDOG >> tristate "DaVinci watchdog" >> depends on ARCH_DAVINCI >> + select WATCHDOG_CORE >> + select WATCHDOG_NOWAYOUT > > Is this mandatory, ie is it correct that the watchdog can not be stopped > once started ? > > Assuming it is, Yes, it is. Davinci WDT can't be stopped and once it's expired - it can be rearmed only after hardware reset. > > Reviewed-by: Guenter Roeck > Thanks a lot for your review. Regards, -grygorii