From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [RFC 01/23] gpio/omap: raw read and write endian fix Date: Tue, 19 Nov 2013 17:51:18 +0100 Message-ID: <528B9706.1070805@collabora.co.uk> References: <1384560086-11994-1-git-send-email-taras.kondratiuk@linaro.org> <1384560086-11994-2-git-send-email-taras.kondratiuk@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: Linus Walleij Cc: Taras Kondratiuk , ext Tony Lindgren , Linux-OMAP , linaro-networking@linaro.org, Victor Kamensky , Santosh Shilimkar , Kevin Hilman , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On 11/19/2013 10:29 AM, Linus Walleij wrote: > On Sat, Nov 16, 2013 at 1:01 AM, Taras Kondratiuk > wrote: > >> From: Victor Kamensky >> >> All OMAP IP blocks expect LE data, but CPU may operate in BE mode. >> Need to use endian neutral functions to read/write h/w registers. >> I.e instead of __raw_read[lw] and __raw_write[lw] functions code >> need to use read[lw]_relaxed and write[lw]_relaxed functions. >> If the first simply reads/writes register, the second will byteswap >> it if host operates in BE mode. >> >> Changes are trivial sed like replacement of __raw_xxx functions >> with xxx_relaxed variant. >> >> Signed-off-by: Victor Kamensky >> Signed-off-by: Taras Kondratiuk > > Since I generally just dislike __raw accessors I went and applied > this. If it collides with any of Tony's fixup work I might need to > take the patch out again, no big deal. > > Some ACKs would be nice, but unless there are major objections > this stays merged. Looks good to me and also I've tested this patch on a TI DM3730 (Cortex A-8) board in LE mode and found no regressions on devices using a GPIO. Tested-by: Javier Martinez Canillas > > Yours, > Linus Walleij > Thanks a lot and best regards, Javier