From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v5] xenbus_client: extend interface to suppurt multi-page ring Date: Tue, 19 Nov 2013 17:09:29 +0000 Message-ID: <528B9B49.3080902@citrix.com> References: <1384104089-15958-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Viont-0002wJ-Os for xen-devel@lists.xenproject.org; Tue, 19 Nov 2013 17:09:33 +0000 In-Reply-To: <1384104089-15958-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , mattjd@gmail.com List-Id: xen-devel@lists.xenproject.org On 10/11/13 17:21, Wei Liu wrote: > Originally Xen PV drivers only use single-page ring to pass along > information. This might limit the throughput between frontend and > backend. > > The patch extends Xenbus driver to support multi-page ring, which in > general should improve throughput if ring is the bottleneck. Changes to > various frontend / backend to adapt to the new interface are also > included. > > Affected Xen drivers: > * blkfront/back > * netfront/back > * pcifront/back > * tpmfront > > The interface is documented, as before, in xenbus_client.c. It looks ok to me so I guess: Reviewed-by: David Vrabel But, I think this should wait until either: a) There's an in kernel user that uses multipage rings or b) You demonstrate multi page rings have been tested with some sort of unit test. David