[Qemu-devel] [PATCH] Don't crash on keyboard input with no handler

[Don Koch <dkoch@verizon.com>]

Prevent a call to put_kbd if null.

On shutdown of some OSes, the keyboard handler goes away before the
system is down. If a key is typed during this window, qemu crashes.

Signed-off-by: Don Koch <dkoch@verizon.com>
---
I left the printf call, originally for testing, but useful as a sanity
check if the user wonders why his keyboard input was ignored. AFAIC,
it can be removed.

PS: Anthony, your address in the MAINTAINER file is still at ibm.
I assume that is no longer correct, yes?

 ui/input.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ui/input.c b/ui/input.c
index 92c44ca..28ef6a6 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -415,8 +415,10 @@ void kbd_put_keycode(int keycode)
         return;
     }
     if (entry) {
-        entry->put_kbd(entry->opaque, keycode);
+        if (entry->put_kbd)
+            entry->put_kbd(entry->opaque, keycode);
+        else
+            printf("%s: no keyboard handler\n", __FUNCTION__);
     }
 }

-- 
1.8.1.4