From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by kanga.kvack.org (Postfix) with ESMTP id 11D2B6B0035 for ; Tue, 19 Nov 2013 16:27:44 -0500 (EST) Received: by mail-pa0-f42.google.com with SMTP id lj1so3159203pab.29 for ; Tue, 19 Nov 2013 13:27:44 -0800 (PST) Received: from psmtp.com ([74.125.245.172]) by mx.google.com with SMTP id v7si12484398pbi.338.2013.11.19.13.27.42 for ; Tue, 19 Nov 2013 13:27:43 -0800 (PST) Message-ID: <528BD7B8.4030108@oracle.com> Date: Tue, 19 Nov 2013 14:27:20 -0700 From: Khalid Aziz MIME-Version: 1.0 Subject: Re: [PATCH 2/3] mm: hugetlb: use get_page_foll in follow_hugetlb_page References: <1384537668-10283-1-git-send-email-aarcange@redhat.com> <1384537668-10283-3-git-send-email-aarcange@redhat.com> In-Reply-To: <1384537668-10283-3-git-send-email-aarcange@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pravin Shelar , Greg Kroah-Hartman , Ben Hutchings , Christoph Lameter , Johannes Weiner , Mel Gorman , Rik van Riel , Andi Kleen , Minchan Kim , Linus Torvalds On 11/15/2013 10:47 AM, Andrea Arcangeli wrote: > get_page_foll is more optimal and is always safe to use under the PT > lock. More so for hugetlbfs as there's no risk of race conditions with > split_huge_page regardless of the PT lock. > > Signed-off-by: Andrea Arcangeli Reviewed-by: Khalid Aziz -- Khalid -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512Ab3KSV16 (ORCPT ); Tue, 19 Nov 2013 16:27:58 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48377 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967Ab3KSV1z (ORCPT ); Tue, 19 Nov 2013 16:27:55 -0500 Message-ID: <528BD7B8.4030108@oracle.com> Date: Tue, 19 Nov 2013 14:27:20 -0700 From: Khalid Aziz Organization: Oracle Corp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Andrea Arcangeli , Andrew Morton CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pravin Shelar , Greg Kroah-Hartman , Ben Hutchings , Christoph Lameter , Johannes Weiner , Mel Gorman , Rik van Riel , Andi Kleen , Minchan Kim , Linus Torvalds Subject: Re: [PATCH 2/3] mm: hugetlb: use get_page_foll in follow_hugetlb_page References: <1384537668-10283-1-git-send-email-aarcange@redhat.com> <1384537668-10283-3-git-send-email-aarcange@redhat.com> In-Reply-To: <1384537668-10283-3-git-send-email-aarcange@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/2013 10:47 AM, Andrea Arcangeli wrote: > get_page_foll is more optimal and is always safe to use under the PT > lock. More so for hugetlbfs as there's no risk of race conditions with > split_huge_page regardless of the PT lock. > > Signed-off-by: Andrea Arcangeli Reviewed-by: Khalid Aziz -- Khalid