From: Antti Miettinen <amiettinen@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"davidlohr@hp.com" <davidlohr@hp.com>,
"matt.fleming@intel.com" <matt.fleming@intel.com>,
"kzak@redhat.com" <kzak@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH] fs: partitions: efi: Fix bound check
Date: Wed, 20 Nov 2013 08:18:50 +0100 [thread overview]
Message-ID: <528C625A.4040509@nvidia.com> (raw)
In-Reply-To: <20131119160438.f1cce64660ab5c545be8baa9@linux-foundation.org>
On 20.11.2013 02:04, Andrew Morton wrote:
> On Fri, 15 Nov 2013 19:14:22 +0200 (EET) Antti P Miettinen
> <amiettinen@nvidia.com> wrote:
>
> > Use ARRAY_SIZE instead of sizeof to get proper max for label
> > length.
> >
> > Signed-off-by: Antti P Miettinen <amiettinen@nvidia.com>
> > Reviewed-by: Hiroshi Doyu <hdoyu@nvidia.com>
> > Tested-by: Hiroshi Doyu <hdoyu@nvidia.com>
>
> When fixing a bug, please provide a description of the user-visible
> impact of that bug. This is so that others can decide which kernel
> version(s) need the patch.
>
> Hiroshi Doyu tested this patch, so I assume there was some observable
> misbehaviour to test. Please fully describe that.
Since this is just a read out of bounds it's not that bad, but the
problem becomes user-visible e.g. if one tries to use
CONFIG_DEBUG_PAGEALLOC and CONFIG_DEBUG_RODATA, at least with some
enhancements from Hiroshi. Of course the destination array can contain
garbage when we read beyond the end of source array so that would be
another user-visible problem.
Should I send a new version with better commit message?
--Antti
next prev parent reply other threads:[~2013-11-20 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 17:14 [PATCH] fs: partitions: efi: Fix bound check Antti P Miettinen
2013-11-20 0:04 ` Andrew Morton
2013-11-20 7:18 ` Antti Miettinen [this message]
2013-11-20 7:36 ` Hiroshi Doyu
2013-11-20 17:46 ` Davidlohr Bueso
2013-11-20 1:06 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C625A.4040509@nvidia.com \
--to=amiettinen@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davidlohr@hp.com \
--cc=hdoyu@nvidia.com \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.