From: Thomas Richter <thor@math.tu-berlin.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Added a lower limit for the watermark setting
Date: Wed, 20 Nov 2013 10:18:58 +0100 [thread overview]
Message-ID: <528C7E82.9030600@math.tu-berlin.de> (raw)
In-Reply-To: <24336_1384879265_528B94A1_24336_14365_1_20131119164139.GE5794@phenom.ffwll.local>
Am 19.11.2013 17:41, schrieb Daniel Vetter:
> On Tue, Nov 19, 2013 at 05:15:09PM +0100, Thomas Richter wrote:
>> Hi Daniel, dear intel experts,
>>
>> please find a patch attached that finally addresses the display
>> flicker on i830 chipsets. This
>> patch adds a lower watermark setting in intel_watermark_params{},
>> but keeps it zero for
>> all but the i830 chipsets. The necessary new defines are in i915_reg.h.
> I think we ned to split out the gen2/3 single/dual pipe watermark code a
> bit better from everything else. A bugfix for i830M shouldn't really
> affect snb ;-)
Actually, the fun part is that it does not because all the lower limits
are zero for all other architectures.
>
> I've pushed out my current (and rather broken) wip branch with my idea on
> the take to
>
> http://cgit.freedesktop.org/~danvet/drm/log/?h=for-thomas
Could you please help me here how to apply it? I'm not very experienced
with git, and it does not seem to fit to the sources of
intel_pm.c I have. Do I first need to instruct git to download another
branch? I'm currently at drm-intel-nightly.
Thanks,
Thomas
next prev parent reply other threads:[~2013-11-20 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 6:38 [PATCH] drm/i915: Replicate BIOS eDP bpp clamping hack for hsw Daniel Vetter
2013-11-19 15:51 ` [Intel-gfx] " Ville Syrjälä
2013-11-19 16:01 ` Daniel Vetter
[not found] ` <24336_1384876863_528B8B3F_24336_14011_1_20131119160127.GC5794@phenom.ffwll.local>
2013-11-19 16:15 ` [PATCH] Added a lower limit for the watermark setting Thomas Richter
2013-11-19 16:41 ` Daniel Vetter
[not found] ` <24336_1384879265_528B94A1_24336_14365_1_20131119164139.GE5794@phenom.ffwll.local>
2013-11-20 9:18 ` Thomas Richter [this message]
2013-11-20 9:27 ` Daniel Vetter
[not found] ` <24336_1384939634_528C8071_24336_18909_1_CAKMK7uH2VXy05gW7yCpkzUCe9nO+e9XU+jYEq8RaNKOXj4G2iw@mail.gmail.com>
2013-11-20 10:50 ` Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C7E82.9030600@math.tu-berlin.de \
--to=thor@math.tu-berlin.de \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.