All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Wroblewski <tomasz.wroblewski@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: TSC trouble in hvm linux, after host S3
Date: Wed, 20 Nov 2013 12:55:15 +0100	[thread overview]
Message-ID: <528CA323.9040604@citrix.com> (raw)
In-Reply-To: <528CB0510200007800104FC0@nat28.tlf.novell.com>

On 11/20/2013 12:51 PM, Jan Beulich wrote:
>>>> On 20.11.13 at 12:41, Tomasz Wroblewski <tomasz.wroblewski@citrix.com> wrote:
>> I've since found out that VMCS seems to provide tsc offsetting capabilities;
>> adding something like
>>
>>           for_each_vcpu ( d, v )
>>           {
>>               if (v->vcpu_id == 0)
>>                   hvm_set_guest_tsc(v, 0);
>>           }
>>
>> inside hvm_s3_resume (xen/arch/x86/hvm/hvm.c) fixed this for me; any comment
>> on such a solution?
>
> This sounds plausible, but I'd prefer it to be done alongside the other
> state resetting done for S3 (which all happen in hvm_s3_suspend()).
> Unless that doesn't work, of course.
>
All right, thanks! I'll try it out and post a patch, I think it should work. I've only reset the tsc on vcpu 0 since I've noticed same is 
done in hvm_vcpu_initialize(), is that enough?

> Jan
>

  reply	other threads:[~2013-11-20 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 10:57 TSC trouble in hvm linux, after host S3 Tomasz Wroblewski
2013-11-20 11:41 ` Tomasz Wroblewski
2013-11-20 11:51   ` Jan Beulich
2013-11-20 11:55     ` Tomasz Wroblewski [this message]
2013-11-20 13:14       ` Jan Beulich
2013-11-20 12:07     ` Tomasz Wroblewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528CA323.9040604@citrix.com \
    --to=tomasz.wroblewski@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.