From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: keystone: gate: fix error handling on init
Date: Wed, 20 Nov 2013 09:51:07 -0500 [thread overview]
Message-ID: <528CCC5B.4010204@ti.com> (raw)
In-Reply-To: <1384949341-26486-1-git-send-email-grygorii.strashko@ti.com>
On Wednesday 20 November 2013 07:09 AM, Grygorii Strashko wrote:
> This patch fixes Keystone gate control clock driver initialization path:
> 1) clk_register_psc() returns error code and not a pure pointer, hence
> its return value need to be checked using IS_ERR(clk) macro.
>
> 2) Mapped IO memory isn't unmapped in case of errors, hence fix it.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Looks good. Thanks !!
Mike, If you are ok can you please consider it for fixes ?
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Mike Turquette <mturquette@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: keystone: gate: fix error handling on init
Date: Wed, 20 Nov 2013 09:51:07 -0500 [thread overview]
Message-ID: <528CCC5B.4010204@ti.com> (raw)
In-Reply-To: <1384949341-26486-1-git-send-email-grygorii.strashko@ti.com>
On Wednesday 20 November 2013 07:09 AM, Grygorii Strashko wrote:
> This patch fixes Keystone gate control clock driver initialization path:
> 1) clk_register_psc() returns error code and not a pure pointer, hence
> its return value need to be checked using IS_ERR(clk) macro.
>
> 2) Mapped IO memory isn't unmapped in case of errors, hence fix it.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Looks good. Thanks !!
Mike, If you are ok can you please consider it for fixes ?
Regards,
Santosh
next prev parent reply other threads:[~2013-11-20 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 12:09 [PATCH] clk: keystone: gate: fix error handling on init Grygorii Strashko
2013-11-20 12:09 ` Grygorii Strashko
2013-11-20 14:51 ` Santosh Shilimkar [this message]
2013-11-20 14:51 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528CCC5B.4010204@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.