Re: [PATCH] mac80211: use capped prob when computing throughputs

[Felix Fietkau <nbd@openwrt.org>]

On 2013-11-20 18:04, Karl Beldan wrote:
> On Wed, Nov 20, 2013 at 05:57:06PM +0100, Felix Fietkau wrote:
>> On 2013-11-20 08:32, Felix Fietkau wrote:
>> > On 2013-11-20 01:51, Karl Beldan wrote:
>> >> From: Karl Beldan <karl.beldan@rivierawaves.com>
>> >> 
>> >> Commit 3e8b1eb "mac80211/minstrel_ht: improve rate selection stability"
>> >> introduced a local capped prob in minstrel_ht_calc_tp but omitted to use
>> >> it to compute the rate throughput.
>> >> 
>> >> Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
>> >> CC: Felix Fietkau <nbd@openwrt.org>
>> > Nice catch!
>> > Acked-by: Felix Fietkau <nbd@openwrt.org>
>> Sorry, I need to revoke that ACK - there's a bug in this patch:
>> 
>> > -	tp = 1000000 * ((mr->probability * 1000) / nsecs);
>> > +	tp = 1000000 * (prob * 1000) / nsecs;
>> Removing the outer () is wrong, it leads to overflow that makes all
>> throughput values 0.
>> 
> Do you handle this one or I resend ?
Please resend.

- Felix