From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VjBu9-0003bb-Eh
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 12:49:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VjBu4-0004cO-9o
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 12:49:33 -0500
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:47746)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VjBu4-0004cC-3D
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 12:49:28 -0500
Message-ID: <528CF623.6030606@weilnetz.de>
Date: Wed, 20 Nov 2013 18:49:23 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <CEB25C37.8743%Tomoki.Sekiyama@hds.com>
In-Reply-To: <CEB25C37.8743%Tomoki.Sekiyama@hds.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h
	compile error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

Am 20.11.2013 18:40, schrieb Tomoki Sekiyama:
> Hi Stefan,
>
>
> On 11/20/13 4:16 , "Stefan Hajnoczi" <stefanha@gmail.com> wrote:
>> Sorry, I forgot to CC qemu-devel on this:
>>
>> On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi <stefanha@gmail.com>
>> wrote:
>>> Hi,
>>> The mingw32 build is failing as follows:
>>>
>>> In file included from qga/vss-win32.c:17:
>>> ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm'
>>> or '__attribute__' before 'requester_init'
>>> ./qga/vss-win32/requester.h:32: error: expected '=', ',', ';', 'asm'
>>> or '__attribute__' before 'requester_deinit'
>>>
>>> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/783
>>>
>>> It's important that we keep the QEMU buildbot working so that compile
>>> errors and test failures are caught before release.  The buildbot is
>>> currently in bad shape (lots of failures), so I am sending out emails
>>> requesting help.
>>>
>>> I'm emailing you since you are familiar with the code and might be
>>> able to fix this issue.  Do you have time to investigate?
>>>
>>> If not, please CC folks who can help.
>>>
>>> Thanks,
>>> Stefan
> Thanks for letting me know this.
>
> I'm investigating the issue, but it looks already fixed in the code in
> the upstream git tree, by commit ba1c293109:
>     "qga: Fix compilation for old version of MinGW"
>
> Could you try this fix?
>
> Thanks,
>
> Tomoki Sekiyama
>

That's correct, it should be fixed now and we'll see the result
automatically in the next buildbot run.

>>From Anthony's commit time, I had expected that it would already be
fixed today (in the last build), but obviously the buildbot does not
pull from qemu.org (or qemu-project.org) - otherwise it would have
pulled the fix...

Regards,
Stefan W.