Re: [PATCH 05/12] ACPI: ARM: exclude calls on ARM platforms, not include them on x86

[Al Stone <al.stone@linaro.org>]

On 11/17/2013 03:08 PM, Rafael J. Wysocki wrote:
> On Saturday, November 09, 2013 06:36:15 PM al.stone@linaro.org wrote:
>> From: Al Stone <ahs3@redhat.com>
>>
>> Corrected #ifdef so that DMI is not used on ARM platforms which are
>> currently implementing reduced HW mode.
>
> Please define an empty dmi_check_system() stub for ARM/ARM64 then.
>
> Generally, please avoid adding compiler directives into function bodies if
> possible.

Will do.

>> Signed-off-by: Al Stone <al.stone@linaro.org>
>> ---
>>   drivers/acpi/bus.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>> index 6a54dd5..f41949a 100644
>> --- a/drivers/acpi/bus.c
>> +++ b/drivers/acpi/bus.c
>> @@ -513,11 +513,15 @@ void __init acpi_early_init(void)
>>
>>   	acpi_gbl_permanent_mmap = 1;
>>
>> +#if !(CONFIG_ARM || CONFIG_ARM64)
>>   	/*
>> +	 * NB: ARM does not use DMI at present.
>> +	 *
>>   	 * If the machine falls into the DMI check table,
>>   	 * DSDT will be copied to memory
>>   	 */
>>   	dmi_check_system(dsdt_dmi_table);
>> +#endif
>>
>>   	status = acpi_reallocate_root_table();
>>   	if (ACPI_FAILURE(status)) {
>>


-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------