From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33002)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VjHdr-0006DC-5A
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 18:57:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VjHdm-0004D0-Ik
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 18:57:07 -0500
Received: from [222.73.24.84] (port=51988 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VjHdm-0004Cn-6T
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 18:57:02 -0500
Message-ID: <528D4BDB.3040502@cn.fujitsu.com>
Date: Thu, 21 Nov 2013 07:55:07 +0800
From: Li Guang <lig.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1384934003-26036-1-git-send-email-lig.fnst@cn.fujitsu.com>
	<CAFEAcA9XZ6d67M2Z3RKeWg04xZfCfQVxnNeG2FnKya4bbcS=kg@mail.gmail.com>
In-Reply-To: <CAFEAcA9XZ6d67M2Z3RKeWg04xZfCfQVxnNeG2FnKya4bbcS=kg@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8; format=flowed
Subject: Re: [Qemu-devel] [PATCH 0/4] add sunxi machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Hi, Peter

Peter Maydell wrote:
> On 20 November 2013 07:53, liguang<lig.fnst@cn.fujitsu.com>  wrote:
>    
>> this patch-set implemented a device-reduced
>> machine type for Allwinner's sunxi series SoC,
>> like sunxi-4i/5i/7i ...
>>      
>    
>> Li Guang (4)
>>           hw/arm: add new machine type sunxi
>>           hw/arm/sunxi-soc: add interrupt controller
>>           hw/arm/sunxi-soc: add sunxi timer
>>           hw/arm/sunxi-soc: really initialize sunxi machine
>>      
> Hi. Thanks for this patch set. I see you've put all the code
> into one file in hw/arm, but we prefer each device model
> to go in its own file in the right subdirectory of hw/. So
> you put the interrupt controller under hw/intc/, the
> timer under hw/timer/, and only the top level board model
> lives under hw/arm. If you could restructure the
> patches this way that would be great.
>
> You'll also need to add VMState descriptions to your
> devices so they can be migrated.
>
>    
OK, let me split it into 3 files, and try to add VMstate.

Thanks!