From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 10/16] xen: arm: enable synchronous console while starting secondary CPUs Date: Thu, 21 Nov 2013 13:40:49 +0000 Message-ID: <528E0D61.3070703@linaro.org> References: <1384958746.6071.64.camel@kazak.uk.xensource.com> <1384958897-13074-10-git-send-email-ian.campbell@citrix.com> <528CF1E5.9080303@linaro.org> <1384969031.6071.100.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384969031.6071.100.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: pranavkumar@linaro.org, stefano.stabellini@eu.citrix.com, tim@xen.org, Anup Patel , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/20/2013 05:37 PM, Ian Campbell wrote: > On Wed, 2013-11-20 at 17:31 +0000, Julien Grall wrote: >> On 11/20/2013 02:48 PM, Ian Campbell wrote: >>> If CONFIG_EARLY_PRINTK is in use then this gets all interleaved with the >>> standard logging otherwise. >>> >> >> Before the discussion IRL, it was not clear to me that you want to >> directly "flush" the console buffer when prinkt is called. Can you >> improve your commit message? > > Sure. How about: > > xen: arm: enable synchronous console while starting secondary > CPUs > > Setting synchronous console ensures that any printk hits the > buffer immediately and that any outstanding queued log messages > are flushed. This ensures that such log messages are not being > printed while the secondary CPU may be using early_printk during > early bringup. > > Signed-off-by: Ian Campbell This commit message looks better for me. -- Julien Grall