All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Scherer <Konrad.Scherer@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [master][dora][PATCH 2/2] perf: Disable -Werror flag
Date: Thu, 21 Nov 2013 10:26:39 -0500	[thread overview]
Message-ID: <528E262F.9050601@windriver.com> (raw)
In-Reply-To: <1385019198-24458-3-git-send-email-mark.hatle@windriver.com>

On 13-11-21 02:33 AM, Mark Hatle wrote:
> From: Konrad Scherer <Konrad.Scherer@windriver.com>
>
> If the sed command does not run before make is invoked, the compile
> fails. Defining the environment variable is the proper way to disable
> warnings as errors build option and eliminates the race condition.
>
> Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>   meta/recipes-kernel/perf/perf.bb | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 138595d..1b889aa 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -40,6 +40,7 @@ export STAGING_INCDIR
>   export STAGING_LIBDIR
>   export BUILD_SYS
>   export HOST_SYS
> +export WERROR = "0"
>
>   do_populate_lic[depends] += "virtual/kernel:do_populate_sysroot"
>
> @@ -118,10 +119,6 @@ do_install() {
>   	fi
>   }
>
> -do_configure_prepend () {
> -    sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
> -}
> -

This is will not work for kernels < 3.1. I did submit another patch 
which works for all kernel versions.

-- 
Konrad Scherer, MTS, Linux Products Group, Wind River


      reply	other threads:[~2013-11-21 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  7:33 [master][dora][PATCH 0/2] Few perf fixes Mark Hatle
2013-11-21  7:33 ` [master][dora][PATCH 1/2] perf: disallow debug optimization Mark Hatle
2013-11-21 14:25   ` Phil Blundell
2013-11-21 14:35     ` Richard Purdie
2013-11-21 14:48       ` Mark Hatle
2013-11-21 17:43       ` Phil Blundell
2013-11-21 14:47     ` Mark Hatle
2013-11-21 15:57       ` Phil Blundell
2013-11-21 21:22         ` Phil Blundell
2013-11-21  7:33 ` [master][dora][PATCH 2/2] perf: Disable -Werror flag Mark Hatle
2013-11-21 15:26   ` Konrad Scherer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528E262F.9050601@windriver.com \
    --to=konrad.scherer@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.