From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCHv5 10/20] arm: dts: add omap4430 thermal data Date: Thu, 21 Nov 2013 11:36:13 -0400 Message-ID: <528E286D.50100@ti.com> References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-11-git-send-email-eduardo.valentin@ti.com> <20131120123245.GA3242@amd.pavel.ucw.cz> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0656805260706730323==" Return-path: In-Reply-To: <20131120123245.GA3242@amd.pavel.ucw.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Pavel Machek Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, wni@nvidia.com, durgadoss.r@intel.com, ian.campbell@citrix.com, pawel.moll@arm.com, swarren@wwwdotorg.org, Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, lm-sensors@lm-sensors.org, Eduardo Valentin , linux-arm-kernel@lists.infradead.org, =?ISO-8859-1?Q?Beno=EEt_Cousson?= , grant.likely@linaro.org, Russell King , rui.zhang@intel.com, linux-omap@vger.kernel.org, linux@roeck-us.net List-Id: linux-omap@vger.kernel.org --===============0656805260706730323== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k" --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 20-11-2013 08:32, Pavel Machek wrote: > HI! >=20 >> This patch changes the dtsi entry on omap4430 to contain >> the thermal data. This data will enable the passive >> cooling with CPUfreq cooling device at 100C and the >> system will do a thermal shutdown at 125C. >> >> Cc: "Beno=EEt Cousson" >> Cc: Tony Lindgren >> Cc: Russell King >> Cc: linux-omap@vger.kernel.org >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin >> --- >> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap4= 43x.dtsi >> index bcf455e..e9c97d6 100644 >> --- a/arch/arm/boot/dts/omap443x.dtsi >> +++ b/arch/arm/boot/dts/omap443x.dtsi >> @@ -12,7 +12,7 @@ >> =20 >> / { >> cpus { >> - cpu@0 { >> + cpu0: cpu@0 { >> /* OMAP443x variants OPP50-OPPNT */ >> operating-points =3D < >> /* kHz uV */ >=20 > I see you also add labels to various other entries... I think I didn't quite get your point here. Can you please elaborate? This label has been added because it will be used in thermal zone while referencing the cooling device. >=20 >> @@ -25,9 +25,15 @@ >> }; >> }; >> =20 >> - bandgap { >> + thermal-zones{ >=20 > You may want to include space here. OK. >=20 >> + #include "omap4-cpu-thermal.dtsi" >> + }; >> + >> + bandgap: bandgap { >> reg =3D <0x4a002260 0x4 >> 0x4a00232C 0x4>; >> compatible =3D "ti,omap4430-bandgap"; >> + >> + #thermal-sensor-cells =3D <0>; >> }; >> }; >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlKOKG0ACgkQCXcVR3XQvP2npgEAxbfIMuRDvRE62RLB0vNNBJZi h70ppZC7HXSQYLS9an4A/1/i5UmTN/9oMYPgz4cCiwNsCLAgWpwHm44gDmu7sspq =ysce -----END PGP SIGNATURE----- --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k-- --===============0656805260706730323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0656805260706730323==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Date: Thu, 21 Nov 2013 15:36:13 +0000 Subject: Re: [lm-sensors] [PATCHv5 10/20] arm: dts: add omap4430 thermal data Message-Id: <528E286D.50100@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============1732255747510193027==" List-Id: References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-11-git-send-email-eduardo.valentin@ti.com> <20131120123245.GA3242@amd.pavel.ucw.cz> In-Reply-To: <20131120123245.GA3242@amd.pavel.ucw.cz> To: Pavel Machek Cc: Eduardo Valentin , swarren@wwwdotorg.org, pawel.moll@arm.com, mark.rutland@arm.com, ian.campbell@citrix.com, rob.herring@calxeda.com, linux@roeck-us.net, rui.zhang@intel.com, wni@nvidia.com, grant.likely@linaro.org, durgadoss.r@intel.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Tony Lindgren , Russell King , linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org --===============1732255747510193027== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k" --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 20-11-2013 08:32, Pavel Machek wrote: > HI! >=20 >> This patch changes the dtsi entry on omap4430 to contain >> the thermal data. This data will enable the passive >> cooling with CPUfreq cooling device at 100C and the >> system will do a thermal shutdown at 125C. >> >> Cc: "Beno=EEt Cousson" >> Cc: Tony Lindgren >> Cc: Russell King >> Cc: linux-omap@vger.kernel.org >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin >> --- >> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap4= 43x.dtsi >> index bcf455e..e9c97d6 100644 >> --- a/arch/arm/boot/dts/omap443x.dtsi >> +++ b/arch/arm/boot/dts/omap443x.dtsi >> @@ -12,7 +12,7 @@ >> =20 >> / { >> cpus { >> - cpu@0 { >> + cpu0: cpu@0 { >> /* OMAP443x variants OPP50-OPPNT */ >> operating-points =3D < >> /* kHz uV */ >=20 > I see you also add labels to various other entries... I think I didn't quite get your point here. Can you please elaborate? This label has been added because it will be used in thermal zone while referencing the cooling device. >=20 >> @@ -25,9 +25,15 @@ >> }; >> }; >> =20 >> - bandgap { >> + thermal-zones{ >=20 > You may want to include space here. OK. >=20 >> + #include "omap4-cpu-thermal.dtsi" >> + }; >> + >> + bandgap: bandgap { >> reg =3D <0x4a002260 0x4 >> 0x4a00232C 0x4>; >> compatible =3D "ti,omap4430-bandgap"; >> + >> + #thermal-sensor-cells =3D <0>; >> }; >> }; >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlKOKG0ACgkQCXcVR3XQvP2npgEAxbfIMuRDvRE62RLB0vNNBJZi h70ppZC7HXSQYLS9an4A/1/i5UmTN/9oMYPgz4cCiwNsCLAgWpwHm44gDmu7sspq =ysce -----END PGP SIGNATURE----- --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k-- --===============1732255747510193027== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors --===============1732255747510193027==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: eduardo.valentin@ti.com (Eduardo Valentin) Date: Thu, 21 Nov 2013 11:36:13 -0400 Subject: [PATCHv5 10/20] arm: dts: add omap4430 thermal data In-Reply-To: <20131120123245.GA3242@amd.pavel.ucw.cz> References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-11-git-send-email-eduardo.valentin@ti.com> <20131120123245.GA3242@amd.pavel.ucw.cz> Message-ID: <528E286D.50100@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20-11-2013 08:32, Pavel Machek wrote: > HI! > >> This patch changes the dtsi entry on omap4430 to contain >> the thermal data. This data will enable the passive >> cooling with CPUfreq cooling device at 100C and the >> system will do a thermal shutdown at 125C. >> >> Cc: "Beno?t Cousson" >> Cc: Tony Lindgren >> Cc: Russell King >> Cc: linux-omap at vger.kernel.org >> Cc: devicetree-discuss at lists.ozlabs.org >> Cc: linux-arm-kernel at lists.infradead.org >> Cc: linux-kernel at vger.kernel.org >> Signed-off-by: Eduardo Valentin >> --- >> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi >> index bcf455e..e9c97d6 100644 >> --- a/arch/arm/boot/dts/omap443x.dtsi >> +++ b/arch/arm/boot/dts/omap443x.dtsi >> @@ -12,7 +12,7 @@ >> >> / { >> cpus { >> - cpu at 0 { >> + cpu0: cpu at 0 { >> /* OMAP443x variants OPP50-OPPNT */ >> operating-points = < >> /* kHz uV */ > > I see you also add labels to various other entries... I think I didn't quite get your point here. Can you please elaborate? This label has been added because it will be used in thermal zone while referencing the cooling device. > >> @@ -25,9 +25,15 @@ >> }; >> }; >> >> - bandgap { >> + thermal-zones{ > > You may want to include space here. OK. > >> + #include "omap4-cpu-thermal.dtsi" >> + }; >> + >> + bandgap: bandgap { >> reg = <0x4a002260 0x4 >> 0x4a00232C 0x4>; >> compatible = "ti,omap4430-bandgap"; >> + >> + #thermal-sensor-cells = <0>; >> }; >> }; > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 295 bytes Desc: OpenPGP digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754552Ab3KUPik (ORCPT ); Thu, 21 Nov 2013 10:38:40 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:40221 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189Ab3KUPih (ORCPT ); Thu, 21 Nov 2013 10:38:37 -0500 Message-ID: <528E286D.50100@ti.com> Date: Thu, 21 Nov 2013 11:36:13 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Pavel Machek CC: Eduardo Valentin , , , , , , , , , , , , , , , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Tony Lindgren , Russell King , , , Subject: Re: [PATCHv5 10/20] arm: dts: add omap4430 thermal data References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-11-git-send-email-eduardo.valentin@ti.com> <20131120123245.GA3242@amd.pavel.ucw.cz> In-Reply-To: <20131120123245.GA3242@amd.pavel.ucw.cz> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 20-11-2013 08:32, Pavel Machek wrote: > HI! >=20 >> This patch changes the dtsi entry on omap4430 to contain >> the thermal data. This data will enable the passive >> cooling with CPUfreq cooling device at 100C and the >> system will do a thermal shutdown at 125C. >> >> Cc: "Beno=EEt Cousson" >> Cc: Tony Lindgren >> Cc: Russell King >> Cc: linux-omap@vger.kernel.org >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin >> --- >> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap4= 43x.dtsi >> index bcf455e..e9c97d6 100644 >> --- a/arch/arm/boot/dts/omap443x.dtsi >> +++ b/arch/arm/boot/dts/omap443x.dtsi >> @@ -12,7 +12,7 @@ >> =20 >> / { >> cpus { >> - cpu@0 { >> + cpu0: cpu@0 { >> /* OMAP443x variants OPP50-OPPNT */ >> operating-points =3D < >> /* kHz uV */ >=20 > I see you also add labels to various other entries... I think I didn't quite get your point here. Can you please elaborate? This label has been added because it will be used in thermal zone while referencing the cooling device. >=20 >> @@ -25,9 +25,15 @@ >> }; >> }; >> =20 >> - bandgap { >> + thermal-zones{ >=20 > You may want to include space here. OK. >=20 >> + #include "omap4-cpu-thermal.dtsi" >> + }; >> + >> + bandgap: bandgap { >> reg =3D <0x4a002260 0x4 >> 0x4a00232C 0x4>; >> compatible =3D "ti,omap4430-bandgap"; >> + >> + #thermal-sensor-cells =3D <0>; >> }; >> }; >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlKOKG0ACgkQCXcVR3XQvP2npgEAxbfIMuRDvRE62RLB0vNNBJZi h70ppZC7HXSQYLS9an4A/1/i5UmTN/9oMYPgz4cCiwNsCLAgWpwHm44gDmu7sspq =ysce -----END PGP SIGNATURE----- --OQGHXilJNQEKWhIDtwI8TunGQ1jD8Fk8k--