From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: shmobile: r8a7790: tidyup clock table order
Date: Thu, 21 Nov 2013 16:22:40 +0000 [thread overview]
Message-ID: <528E3350.2090200@cogentembedded.com> (raw)
In-Reply-To: <8738msep7z.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 21-11-2013 5:35, Kuninori Morimoto wrote:
>>> In this context I think the comment makes sense.
>> I disagree because the clocks declared via CLKDEV_ICK_ID() are by nature
>> the same MSTP clocks as the others. This patch looks dangerously close to the
>> needless churn IMHO.
> From MSTP grouping point of view, you are correct.
> From PM-Runtime/Clock API point of view, this patch is sane.
Please explain what it adds from this PoV. And if this patch is going to
be accepted, I at least would like the dubious "ICK" comment to be removed.
WBR, Sergei
next prev parent reply other threads:[~2013-11-21 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 9:05 [PATCH 5/6] ARM: shmobile: r8a7790: tidyup clock table order Kuninori Morimoto
2013-11-19 17:56 ` Sergei Shtylyov
2013-11-20 0:24 ` Simon Horman
2013-11-20 18:26 ` Sergei Shtylyov
2013-11-21 1:35 ` Kuninori Morimoto
2013-11-21 16:22 ` Sergei Shtylyov [this message]
2013-11-25 0:17 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528E3350.2090200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.