All of lore.kernel.org
 help / color / mirror / Atom feed
From: Loic Dachary <loic@dachary.org>
To: Dietmar Maurer <dietmar@proxmox.com>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: possible bug in init-ceph.in
Date: Thu, 21 Nov 2013 18:18:41 +0100	[thread overview]
Message-ID: <528E4071.3070603@dachary.org> (raw)
In-Reply-To: <24E144B8C0207547AD09C467A8259F7559232FA2@lisa.maurer-it.com>

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

Hi,

I believe there is either a pull request or a ticket with this fix. Definitely a typo ;-)

Cheers

On 21/11/2013 08:23, Dietmar Maurer wrote:
> http://ceph.com/git/?p=ceph.git;a=blob;f=src/init-ceph.in;h=7399abb8f85855f2248c4afb22bf94f2e2f080a2;hb=HEAD
> 
> line 320:
> 
>       if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
> 
> looks strange to me. Maybe that should be:
> 
> -		if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
> +		if [ "${update_crush:-1}" = "1" -o "${update_crush:-1}" = "true" ]; then
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2013-11-21 17:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  7:23 possible bug in init-ceph.in Dietmar Maurer
2013-11-21 17:18 ` Loic Dachary [this message]
2013-11-21 17:57   ` Loic Dachary
2013-11-21 17:59     ` Gregory Farnum
2013-11-22  4:54       ` Dietmar Maurer
2013-11-25  6:08         ` Gregory Farnum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528E4071.3070603@dachary.org \
    --to=loic@dachary.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dietmar@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.