From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCHv5 1/9] of: introduce of_property_for_earch_phandle_with_args() Date: Thu, 21 Nov 2013 11:52:30 -0700 Message-ID: <528E566E.1020704@wwwdotorg.org> References: <1384853593-32202-1-git-send-email-hdoyu@nvidia.com><20131121151218.befbb483c0cf09cdcd4cd4dd@nvidia.com><20131121155649.48C96C406A3@trevor.secretlab.ca> <20131121.192051.747601347584525020.hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131121.192051.747601347584525020.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Hiroshi Doyu , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org" , Stephen Warren , "will.deacon-5wv7dgnIgG8@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org On 11/21/2013 10:20 AM, Hiroshi Doyu wrote: > Grant Likely wrote @ Thu, 21 Nov 2013 16:56:49 +0100: > >> On Thu, 21 Nov 2013 15:12:18 +0200, Hiroshi Doyu wrote: >>> On Thu, 21 Nov 2013 13:43:28 +0100 >>> Grant Likely wrote: >>> >>>> On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu wrote: >>>>> The following pattern of code is tempting: >>>>> >>>>> for (i = 0; !of_parse_phandle_with_args(np, list, cells, i, args); i++) >>>>> >>>>> Signed-off-by: Hiroshi Doyu >>>> >>>> That's a very minimal commit message. Can you elaborate please. >>> >>> The above can be: >>> >>> " >>> The following pattern of code is tempting to add a new member for >>> of_property_for_each_*() family as an idiom. >>> >>> for (i = 0; >>> !of_parse_phandle_with_args(np, list, cells, i, args); i++) >>> ; >>> " >> >> I really do like commit messages to be full enough that a future reader >> can figure out why a patch was written. ie: > > Updated as: > > [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args() > http://lists.linuxfoundation.org/pipermail/iommu/2013-November/007063.html > > This doesn't depend on anything and this can be merged > independetly. Thanks for your help. Well, that patch doesn't depend /on/ anything, but something in the rest of the series does depend /on it/. As such, this patch can't be merged completely independently; it has to either: a) Go into whatever branch the rest of the series goes into. b) Go into a topic branch in the DT tree, which is then both merged into the main/regular DT tree /and/ used as a base for the rest of this series. Dependencies work two ways! (That is, unless this 1 patch gets merged into 3.14, and the rest of series doesn't get merged until 3.15. In that case, we can ignore the dependencies). From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Thu, 21 Nov 2013 11:52:30 -0700 Subject: [PATCHv5 1/9] of: introduce of_property_for_earch_phandle_with_args() In-Reply-To: <20131121.192051.747601347584525020.hdoyu@nvidia.com> References: <1384853593-32202-1-git-send-email-hdoyu@nvidia.com><20131121151218.befbb483c0cf09cdcd4cd4dd@nvidia.com><20131121155649.48C96C406A3@trevor.secretlab.ca> <20131121.192051.747601347584525020.hdoyu@nvidia.com> Message-ID: <528E566E.1020704@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/21/2013 10:20 AM, Hiroshi Doyu wrote: > Grant Likely wrote @ Thu, 21 Nov 2013 16:56:49 +0100: > >> On Thu, 21 Nov 2013 15:12:18 +0200, Hiroshi Doyu wrote: >>> On Thu, 21 Nov 2013 13:43:28 +0100 >>> Grant Likely wrote: >>> >>>> On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu wrote: >>>>> The following pattern of code is tempting: >>>>> >>>>> for (i = 0; !of_parse_phandle_with_args(np, list, cells, i, args); i++) >>>>> >>>>> Signed-off-by: Hiroshi Doyu >>>> >>>> That's a very minimal commit message. Can you elaborate please. >>> >>> The above can be: >>> >>> " >>> The following pattern of code is tempting to add a new member for >>> of_property_for_each_*() family as an idiom. >>> >>> for (i = 0; >>> !of_parse_phandle_with_args(np, list, cells, i, args); i++) >>> ; >>> " >> >> I really do like commit messages to be full enough that a future reader >> can figure out why a patch was written. ie: > > Updated as: > > [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args() > http://lists.linuxfoundation.org/pipermail/iommu/2013-November/007063.html > > This doesn't depend on anything and this can be merged > independetly. Thanks for your help. Well, that patch doesn't depend /on/ anything, but something in the rest of the series does depend /on it/. As such, this patch can't be merged completely independently; it has to either: a) Go into whatever branch the rest of the series goes into. b) Go into a topic branch in the DT tree, which is then both merged into the main/regular DT tree /and/ used as a base for the rest of this series. Dependencies work two ways! (That is, unless this 1 patch gets merged into 3.14, and the rest of series doesn't get merged until 3.15. In that case, we can ignore the dependencies). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238Ab3KUTAW (ORCPT ); Thu, 21 Nov 2013 14:00:22 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:35513 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754702Ab3KUTAV (ORCPT ); Thu, 21 Nov 2013 14:00:21 -0500 Message-ID: <528E566E.1020704@wwwdotorg.org> Date: Thu, 21 Nov 2013 11:52:30 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Hiroshi Doyu , "grant.likely@linaro.org" CC: Stephen Warren , "will.deacon@arm.com" , "thierry.reding@gmail.com" , "galak@codeaurora.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lorenzo.pieralisi@arm.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv5 1/9] of: introduce of_property_for_earch_phandle_with_args() References: <1384853593-32202-1-git-send-email-hdoyu@nvidia.com><20131121151218.befbb483c0cf09cdcd4cd4dd@nvidia.com><20131121155649.48C96C406A3@trevor.secretlab.ca> <20131121.192051.747601347584525020.hdoyu@nvidia.com> In-Reply-To: <20131121.192051.747601347584525020.hdoyu@nvidia.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2013 10:20 AM, Hiroshi Doyu wrote: > Grant Likely wrote @ Thu, 21 Nov 2013 16:56:49 +0100: > >> On Thu, 21 Nov 2013 15:12:18 +0200, Hiroshi Doyu wrote: >>> On Thu, 21 Nov 2013 13:43:28 +0100 >>> Grant Likely wrote: >>> >>>> On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu wrote: >>>>> The following pattern of code is tempting: >>>>> >>>>> for (i = 0; !of_parse_phandle_with_args(np, list, cells, i, args); i++) >>>>> >>>>> Signed-off-by: Hiroshi Doyu >>>> >>>> That's a very minimal commit message. Can you elaborate please. >>> >>> The above can be: >>> >>> " >>> The following pattern of code is tempting to add a new member for >>> of_property_for_each_*() family as an idiom. >>> >>> for (i = 0; >>> !of_parse_phandle_with_args(np, list, cells, i, args); i++) >>> ; >>> " >> >> I really do like commit messages to be full enough that a future reader >> can figure out why a patch was written. ie: > > Updated as: > > [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args() > http://lists.linuxfoundation.org/pipermail/iommu/2013-November/007063.html > > This doesn't depend on anything and this can be merged > independetly. Thanks for your help. Well, that patch doesn't depend /on/ anything, but something in the rest of the series does depend /on it/. As such, this patch can't be merged completely independently; it has to either: a) Go into whatever branch the rest of the series goes into. b) Go into a topic branch in the DT tree, which is then both merged into the main/regular DT tree /and/ used as a base for the rest of this series. Dependencies work two ways! (That is, unless this 1 patch gets merged into 3.14, and the rest of series doesn't get merged until 3.15. In that case, we can ignore the dependencies).