From: Karol Babioch <karol@babioch.de>
To: platform-driver-x86@vger.kernel.org
Cc: Mattia Dongili <malattia@linux.it>
Subject: Re: sony_laptop: Default values for keyboard backlight
Date: Fri, 22 Nov 2013 00:05:10 +0100 [thread overview]
Message-ID: <528E91A6.1070403@babioch.de> (raw)
In-Reply-To: <20131118223008.GA4397@taihen.jp>
[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]
Hi,
Am 18.11.2013 23:30, schrieb Mattia Dongili:
> I guess this is not the case on your
> machine. If you don't load sony-laptop module you still have the 10
> seconds timeout that you see in the BIOS? Only _after_ you load the
> module the backlight never goes off?
After playing around with this for a while I think that I narrowed the
issue down (or at least one aspect of it):
So when actually rebooting and/or powering up the device for the first
time, it works just fine by default without setting any module
parameters explicitly. The keyboard backlight is enabled and the timeout
is set to 10 seconds, which is the default.
But as soon as I suspend the machine it absolutely makes a difference
whether or not the module parameter is set. When it is not set
explicitly (sysfs interface reporting "-1") the keyboard backlight will
stay on from the moment I resume the machine and press a button. When
the module parameters are set explicitly it works just fine and as
expected.
Does this make any sense from your perspective? Maybe it's not the whole
story, but only one aspect of it. Is this something you can check and/or
verify?
> From the DSDTs I have hanging around these models may see the same
> behaviour as you're seeing:
Can't deny or confirm this, but this would be a reasonable guess.
Personally I'm using a Sony Vaio VPCS12C5E. I might provide you the
appropriate DSDT, if it can provide you any more insights.
> One approach could be to make the default setting handle based with
> again 0x137 being different from all others.
Not sure what the right approach would be. When there is absolutely no
way of reading the value before it was set at least once, then I don't
see much of an alternative, but to set it explicitly for these models
with an option to overwrite the default values using the appropriate
module parameters.
You'll definitely have more experience in this field, so it's your call.
Furthermore there are a lot of other models you have to keep in mind ;).
Let me know if you come up with something you might want to test ;).
Best regards,
Karol Babioch
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-21 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 10:48 sony_laptop: Default values for keyboard backlight Karol Babioch
2013-11-18 22:30 ` Mattia Dongili
2013-11-21 23:05 ` Karol Babioch [this message]
2013-11-22 22:11 ` Mattia Dongili
2013-11-25 12:09 ` Karol Babioch
2013-11-25 22:43 ` [PATCH] sony-laptop: do not scribble keyboard backlight registers on resume Mattia Dongili
2013-11-26 4:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528E91A6.1070403@babioch.de \
--to=karol@babioch.de \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.