From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: drjones@redhat.com, ehabkost@redhat.com, lersek@redhat.com,
hutao@cn.fujitsu.com, mtosatti@redhat.com,
peter.huangpeng@huawei.com, lcapitulino@redhat.com,
bsd@redhat.com, anthony@codemonkey.ws, y-goto@jp.fujitsu.com,
pbonzini@redhat.com, afaerber@suse.de, gaowanlong@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH] fixup
Date: Fri, 22 Nov 2013 10:10:45 +0800 [thread overview]
Message-ID: <528EBD25.4080301@cn.fujitsu.com> (raw)
In-Reply-To: <1385086118-11699-2-git-send-email-gaowanlong@cn.fujitsu.com>
Sorry, please ignore this patch.
Thanks,
Wanlong Gao
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> hw/i386/pc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 50ed4cc..74c1f16 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1072,8 +1072,12 @@ PcGuestInfo *pc_guest_info_init(ram_addr_t below_4g_mem_size,
> guest_info->apic_id_limit = pc_apic_id_limit(max_cpus);
> guest_info->apic_xrupt_override = kvm_allows_irq0_override();
> guest_info->numa_nodes = nb_numa_nodes;
> - guest_info->node_mem = g_memdup(node_mem, guest_info->numa_nodes *
> + guest_info->node_mem = g_malloc0(guest_info->numa_nodes *
> sizeof *guest_info->node_mem);
> + for (i = 0; i < nb_numa_nodes; i++) {
> + guest_info->node_mem[i] = numa_info[i].node_mem;
> + }
> +
> guest_info->node_cpu = g_malloc0(guest_info->apic_id_limit *
> sizeof *guest_info->node_cpu);
>
> @@ -1081,7 +1085,7 @@ PcGuestInfo *pc_guest_info_init(ram_addr_t below_4g_mem_size,
> unsigned int apic_id = x86_cpu_apic_id_from_index(i);
> assert(apic_id < guest_info->apic_id_limit);
> for (j = 0; j < nb_numa_nodes; j++) {
> - if (test_bit(i, node_cpumask[j])) {
> + if (test_bit(i, numa_info[j].node_cpu)) {
> guest_info->node_cpu[apic_id] = j;
> break;
> }
>
next prev parent reply other threads:[~2013-11-22 2:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 2:08 [Qemu-devel] [PATCH V16 00/11] Add support for binding guest numa nodes to host numa nodes Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH] fixup Wanlong Gao
2013-11-22 2:10 ` Wanlong Gao [this message]
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 01/11] NUMA: move numa related code to new file numa.c Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 02/11] NUMA: check if the total numa memory size is equal to ram_size Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 03/11] NUMA: Add numa_info structure to contain numa nodes info Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 04/11] NUMA: convert -numa option to use OptsVisitor Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 05/11] NUMA: introduce NumaMemOptions Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 06/11] NUMA: add "-numa mem," options Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 07/11] NUMA: expand MAX_NODES from 64 to 128 Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 08/11] NUMA: parse guest numa nodes memory policy Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 09/11] NUMA: set " Wanlong Gao
2013-11-27 14:35 ` Paolo Bonzini
2013-11-27 15:09 ` Wanlong Gao
2013-11-27 16:19 ` Andrew Jones
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 10/11] NUMA: add qmp command query-numa Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528EBD25.4080301@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=bsd@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.