From: viresh kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Dirk Brandewie <dirk.brandewie@gmail.com>
Cc: Nishanth Menon <nm@ti.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shawn Guo <shawn.guo@linaro.org>, Sripa Bagadia <ceh@ti.com>
Subject: Re: [PATCH] cpufreq: Make sure CPU is running on a freq from freq-table
Date: Fri, 22 Nov 2013 12:36:06 +0530 [thread overview]
Message-ID: <528F025E.70202@linaro.org> (raw)
In-Reply-To: <1980582.Pd2pT79ZWp@vostro.rjw.lan>
On Friday 22 November 2013 03:13 AM, Rafael J. Wysocki wrote:
> On Thursday, November 21, 2013 09:56:32 AM Dirk Brandewie wrote:
>> The scaling driver for the CPU has already loaded and its .init procedure has
>> been called so .target better be callable.
Yeah..
>> Since the scaling driver is responsible maintaining the set of valid frequencies
>> and setting policy->cur I think it is reasonable to have the scaling driver
>> ensure that policy->cur returned from its .init
I agree..
>> and the operating frequency are
>> in sync and match one of the values in its frequency table.
Hmmm, that doesn't necessarily lie in driver's domain but maybe at a common
place like core. That's why we had this patch..
> From that I infer that we should not continue on errors here. Which also is my
> opinion.
Okay.. Code modified to return error on failure.. Will send V2 as soon as patch
is tested by Nishanth..
next prev parent reply other threads:[~2013-11-22 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 7:09 [PATCH] cpufreq: Make sure CPU is running on a freq from freq-table Viresh Kumar
2013-11-21 13:11 ` Rafael J. Wysocki
2013-11-21 15:57 ` Viresh Kumar
2013-11-21 17:56 ` Dirk Brandewie
2013-11-21 21:43 ` Rafael J. Wysocki
2013-11-21 21:43 ` Rafael J. Wysocki
2013-11-22 7:06 ` viresh kumar [this message]
2013-11-22 7:03 ` viresh kumar
2013-11-22 21:43 ` Nishanth Menon
2013-11-22 21:43 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F025E.70202@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=ceh@ti.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.