From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: "Antony N. Pavlov" <antony@niisi.msk.ru>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] gpiolib: import gpio_request_array() from linux 3.7
Date: Fri, 22 Nov 2013 08:57:15 +0100 [thread overview]
Message-ID: <528F0E5B.8010903@gmail.com> (raw)
In-Reply-To: <20131122114958.6d6ec0a93ec910d06216b845@niisi.msk.ru>
On 11/22/2013 08:49 AM, Antony N. Pavlov wrote:
> On Fri, 22 Nov 2013 08:20:08 +0100
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
>> Hi Antony,
>>
>> On Fri, Nov 22, 2013 at 12:11:24AM +0400, Antony Pavlov wrote:
>>> Also import related functions gpio_request_one() and
>>> gpio_free_array().
>>>
>>> This commit imports code from linux 3.7 as
>>> the more recent linux kernel versions use gpiolib descriptors,
>>> see this commit for details:
>>>
>>> commit 372e722ea4dd4ca11c3d04845e11cbc15f32144c
>>> Author: Alexandre Courbot <acourbot@nvidia.com>
>>> Date: Sun Feb 3 01:29:29 2013 +0900
>>>
>>> gpiolib: use descriptors internally
>>>
>>> Make sure gpiolib works internally with descriptors and (chip, offset)
>>> pairs instead of using the global integer namespace. This prepares the
>>> ground for the removal of the global gpio_desc[] array and the
>>> introduction of the descriptor-based GPIO API.
>>>
>>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>>
>> What a pitty, we duplicated some work. I created exactly the same patch
>> recently but haven't posted it yet, shame on me.
>
> I must say "Thanks!" to Sebastian Hesselbarth. It's him who introduced
> get_direction callback. His patch conflicted with patch in my local repo.
> So I made the decision to post my patch as soon as possible.
I added that callback because I needed it for working on Marvell Berlin
support. Don't expect too fancy stuff, but as soon as I find some time
to work out the Chipidea USB device driver, I'll be posting patches for
Chromecast.
The get_direction callback gives valuable information for unknown HW :P
Sebastian
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-11-22 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 20:11 [PATCH 1/2] gpio: unify gpio direction macros names with Linux kernel Antony Pavlov
2013-11-21 20:11 ` [PATCH 2/2] gpiolib: import gpio_request_array() from linux 3.7 Antony Pavlov
2013-11-22 7:20 ` Sascha Hauer
2013-11-22 7:49 ` Antony N. Pavlov
2013-11-22 7:57 ` Sebastian Hesselbarth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F0E5B.8010903@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=antony@niisi.msk.ru \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.