All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: make quota metadata truncation behavior consistent to user space
Date: Fri, 22 Nov 2013 17:56:16 +0800	[thread overview]
Message-ID: <528F2A40.8060502@oracle.com> (raw)
In-Reply-To: <20131122091827.GC32568@infradead.org>

On 11/22 2013 17:18, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 02:04:00PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> In xfs_qm_scall_trunc_qfiles(), we ignore the error if failed to remove
>> the users quota metadata and proceed to remove groups and projects if
>> they are being there.  However, in user space, the remove operation will
>> break and return if failed to remove any kind of quota.
>> Also for v5 super block, we can enabled both group and project quota at
>> the same time, in this case the current error handling will cover the
>> group error with projects but they might failed due to different reasons.
>>
>> It seems we'd better the error handling consistent to the user space and
>> don't trying to remove another kind of quota metadata if the previous
>> operation is failed.
> 
> Looks good.  Just curious, did you manage to reproduce an error
> truncating the quota files?
Yup, I thought it over how to break it while occasionally glanced over this
function for backporting upstream patches this morning, but can not figure
out a simple method.

Thanks,
-Jeff 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-11-22  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22  6:04 [PATCH] xfs: make quota metadata truncation behavior consistent to user space Jeff Liu
2013-11-22  9:18 ` Christoph Hellwig
2013-11-22  9:56   ` Jeff Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528F2A40.8060502@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.