All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] tinymembench: package not supported on MIPS64
Date: Fri, 22 Nov 2013 11:10:47 +0000	[thread overview]
Message-ID: <528F3BB7.1030408@imgtec.com> (raw)
In-Reply-To: <1385117836-26855-1-git-send-email-Vincent.Riera@imgtec.com>

On 11/22/2013 10:57 AM, Vicente Olivert Riera wrote:
> Fixes:
>
>     http://autobuild.buildroot.net/results/bab/bab68bcf8714f215ac0b0c2546fa06608377fbb0/
>
> This package is only supported on MIPS32 platforms. The mips-32.S file included
> in the source code of this package only makes sense to be compiled for MIPS32,
> and also contains hardcoded MIPS32 instructions which are illegal on MIPS64.
> Trying to compile this package on a MIPS64 platform will end with a linkage
> failure due to undefined references.
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>   package/tinymembench/Config.in |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/package/tinymembench/Config.in b/package/tinymembench/Config.in
> index 0d45532..0555b19 100644
> --- a/package/tinymembench/Config.in
> +++ b/package/tinymembench/Config.in
> @@ -1,5 +1,6 @@
>   config BR2_PACKAGE_TINYMEMBENCH
>   	bool "tinymembench"
> +	depends on !BR2_mips64 && !BR2_mips64el
>   	help
>   	  Tinymembench is a simple memory benchmark program, which
>   	  tries to measure the peak bandwidth of sequential memory
>

I guess you could move the 'Fixes $URL' part just above your 
Signed-off-by line. But in any case, it looks good to me. Thanks

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

-- 
markos

  reply	other threads:[~2013-11-22 11:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 10:57 [Buildroot] [PATCH v3] tinymembench: package not supported on MIPS64 Vicente Olivert Riera
2013-11-22 11:10 ` Markos Chandras [this message]
2013-11-22 14:58 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528F3BB7.1030408@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.