From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Meier Subject: Re: [PATCHv4] ASoC: Add support for BCM2835 Date: Fri, 22 Nov 2013 14:32:19 +0100 Message-ID: <528F5CE3.30105@koalo.de> References: <528E4E4A.20403@koalo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by alsa0.perex.cz (Postfix) with ESMTP id 5829A261AC1 for ; Fri, 22 Nov 2013 14:32:24 +0100 (CET) Received: by mail-bk0-f49.google.com with SMTP id my13so791309bkb.22 for ; Fri, 22 Nov 2013 05:32:22 -0800 (PST) In-Reply-To: <528E4E4A.20403@koalo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood , Mark Brown , Stephen Warren , Lars-Peter Clausen Cc: devicetree , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , linux-rpi-kernel , dmaengine , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org > + dev = devm_kzalloc(&pdev->dev, sizeof(*dev), > + GFP_KERNEL); > + if (IS_ERR(base)) > + return PTR_ERR(base); Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev). Is the patch acceptable apart from that now? Greetings, Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian.meier@koalo.de (Florian Meier) Date: Fri, 22 Nov 2013 14:32:19 +0100 Subject: [PATCHv4] ASoC: Add support for BCM2835 In-Reply-To: <528E4E4A.20403@koalo.de> References: <528E4E4A.20403@koalo.de> Message-ID: <528F5CE3.30105@koalo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > + dev = devm_kzalloc(&pdev->dev, sizeof(*dev), > + GFP_KERNEL); > + if (IS_ERR(base)) > + return PTR_ERR(base); Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev). Is the patch acceptable apart from that now? Greetings, Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755693Ab3KVNcZ (ORCPT ); Fri, 22 Nov 2013 08:32:25 -0500 Received: from mail-bk0-f50.google.com ([209.85.214.50]:60390 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755667Ab3KVNcX (ORCPT ); Fri, 22 Nov 2013 08:32:23 -0500 Message-ID: <528F5CE3.30105@koalo.de> Date: Fri, 22 Nov 2013 14:32:19 +0100 From: Florian Meier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Liam Girdwood , Mark Brown , Stephen Warren , Lars-Peter Clausen CC: "alsa-devel@alsa-project.org" , linux-rpi-kernel , devicetree , dmaengine , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCHv4] ASoC: Add support for BCM2835 References: <528E4E4A.20403@koalo.de> In-Reply-To: <528E4E4A.20403@koalo.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + dev = devm_kzalloc(&pdev->dev, sizeof(*dev), > + GFP_KERNEL); > + if (IS_ERR(base)) > + return PTR_ERR(base); Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev). Is the patch acceptable apart from that now? Greetings, Florian