From: "Andreas Färber" <afaerber@suse.de>
To: Peter Lieven <pl@kamp.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane
Date: Fri, 22 Nov 2013 15:43:55 +0100 [thread overview]
Message-ID: <528F6DAB.9040104@suse.de> (raw)
In-Reply-To: <528F3E0D.4040308@redhat.com>
Am 22.11.2013 12:20, schrieb Paolo Bonzini:
> Il 22/11/2013 12:13, Peter Lieven ha scritto:
>>> I see where you come from, but I think the potential for this patch to
>>> break some working configuration (for some definition of working) is too
>>> high. Can you split out the fixes to the "fill in the blanks" logic?
>>
>> I can, but the number of sockets is logal to the parse function.
>
> Not sure why that matters, just make two patches instead of one.
...and please CC me and possibly Eduardo who refactored it last IIRC.
Andreas
>> What would you think is it okay to just send a warning about
>> the illegal config and drop the exit(1).
>
> Yes, that would be okay.
>
> Paolo
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-11-22 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:37 [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane Peter Lieven
2013-11-22 10:16 ` Paolo Bonzini
2013-11-22 11:13 ` Peter Lieven
2013-11-22 11:20 ` Paolo Bonzini
2013-11-22 14:43 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F6DAB.9040104@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.