All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: "linux-rdma
	(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Vladimir Koushnir
	<vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH opensm] Implement atomic update operation for sa_db_file
Date: Fri, 22 Nov 2013 09:57:00 -0500	[thread overview]
Message-ID: <528F70BC.1050907@dev.mellanox.co.il> (raw)
In-Reply-To: <5283BE32.5070804-HInyCGIudOg@public.gmane.org>

Hi Bart,

On 11/13/2013 1:00 PM, Bart Van Assche wrote:
> Isn't an fdatasync() call missing after dump_func() and before fclose()
> ? According to Theodore Ts'o calling fdatasync() or fsync() before
> fclose() is essential during an atomic update. See also
> http://thunk.org/tytso/blog/2009/03/15/dont-fear-the-fsync/ for more
> information.

Thanks for the pointer. Yes, an fsync is appropriate here. Do you want
to send a patch for that or should I just cruft one up ?

-- Hal

> Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-11-22 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 16:27 [PATCH opensm] Implement atomic update operation for sa_db_file Hal Rosenstock
     [not found] ` <5283A88D.9020608-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-11-13 18:00   ` Bart Van Assche
     [not found]     ` <5283BE32.5070804-HInyCGIudOg@public.gmane.org>
2013-11-22 14:57       ` Hal Rosenstock [this message]
     [not found]         ` <528F70BC.1050907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-11-22 15:27           ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528F70BC.1050907@dev.mellanox.co.il \
    --to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=bvanassche-HInyCGIudOg@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.