From mboxrd@z Thu Jan 1 00:00:00 1970 From: Levente Kurusa Subject: Re: Patch Date: Fri, 22 Nov 2013 18:36:48 +0100 Message-ID: <528F9630.6090202@linux.com> References: Reply-To: Levente Kurusa Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arthur Schwalbenberg , Daniel Vetter , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arthur Schwalbenberg List-Id: dri-devel@lists.freedesktop.org 2013-11-22 17:35, Arthur Schwalbenberg: >=20 > From 340fa01dfe8f699e27ece111996ea088bca6b5c4 Mon Sep 17 00:00:00 200= 1 > From: Arthur Schwalbenberg > Date: Thu, 21 Nov 2013 19:42:44 -0500 > Subject: [PATCH] Staging: Fixed compilar warnings and coding style > issues in i915_debugfs.c > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit >=20 > This is a patch fixing both a compilar warning: > =91val=92 may be used uninitialized in this function > and various coding style issues which include line length > warnings and a few errors as defined by 'checkpatch.pl' tool >=20 > Signed-off-by: Arthur Schwalbenberg Hi, When you break 80+ lines into two lines, you should also indent the newly created line so that it shows that it is a part of som= ething. I as well don't think it is worth splitting lines that are 84 character= s long into two lines, that just doesn't make sense. Also, your patch seems (atleast to me) a 'bit' whitespace damaged. --=20 Regards, Levente Kurusa