From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Magenheimer Subject: RE: Dom0 crashing when built with c/s 881 (Was: blktap2: need more than 3 values to unpack) Date: Wed, 3 Jun 2009 18:09:06 -0700 (PDT) Message-ID: <528bc7b9-49da-4716-bd5e-2c0a8bc4439e@default> References: <23856f7d-9491-45a5-8d8c-3c17f7b74741@default> Mime-Version: 1.0 Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <23856f7d-9491-45a5-8d8c-3c17f7b74741@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , Isaku Yamahata Cc: "Xen-Devel (E-mail)" List-Id: xen-devel@lists.xenproject.org > If that doesn't help, I can go add some printk's where that > output is happening and see exactly what forces the failure. Here's what I am seeing. Looks like the drv->bus structure is getting overwritten with ASCII. Driver 'usbfs' needs updating - please use bus_type methods drv->bus->probe =3D 73756f6e (THAT's "nous" I think) drv->probe =3D d1069ab0 drv->bus->remove =3D 00000062 drv->remove =3D d1069960 drv->bus->shutdown =3D 00000000 drv->shutdown =3D 00000000 usbcore: registered new driver usbfs Driver 'hub' needs updating - please use bus_type methods drv->bus->probe =3D 73756f6e drv->probe =3D d1069ab0 drv->bus->remove =3D 00000062 drv->remove =3D d1069960 drv->bus->shutdown =3D 00000000 drv->shutdown =3D 00000000 usbcore: registered new driver hub Driver 'usb' needs updating - please use bus_type methods drv->bus->probe =3D 73756f6e drv->probe =3D d1069570 > -----Original Message----- > From: Dan Magenheimer=20 > Sent: Wednesday, June 03, 2009 4:12 PM > To: Keir Fraser; Isaku Yamahata > Cc: Xen-Devel (E-mail) > Subject: RE: Dom0 crashing when built with c/s 881 (Was: [Xen-devel] > blktap2: need more than 3 values to unpack) >=20 >=20 > > Actually I missed that the dependent code is only built if > > CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got=20 > > one or both > > disabled and hence 882 doesn't break without 881 in your case. >=20 > In case it helps, with 889 and 881 reverted, I am using the > default config which results in CONFIG_PCI_IOMULTI=3Dy and > CONFIG_HOTPLUG_PCI=3Dm. >=20 > > I can't explain that from reading the code. It looks like a=20 > > no-op to me > > unless the new function bus_register_notifier() is called. >=20 > Looking at my boot output on failure, there are those lines: >=20 > "Driver 'xxx' needs updating - please use bus_type methods" >=20 > which is printed in linux/drivers/base/driver.c:driver_register() > if a complex set of circumstances are true. So clearly > something is different. >=20 > If that doesn't help, I can go add some printk's where that > output is happening and see exactly what forces the failure. >=20 > Dan >=20 >=20 > > -----Original Message----- > > From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] > > Sent: Wednesday, June 03, 2009 3:28 PM > > To: Dan Magenheimer; Isaku Yamahata > > Cc: Xen-Devel (E-mail) > > Subject: Re: Dom0 crashing when built with c/s 881 (Was: [Xen-devel] > > blktap2: need more than 3 values to unpack) > >=20 > >=20 > > On 03/06/2009 22:17, "Dan Magenheimer"=20 > > wrote: > >=20 > > >> 1. It only adds extra functionality which by default would > > >> not do anything. > > >> Just reading the patch I can see it's harmless by itself=20 > > as it merely > > >> introduces a new notifier chain which noone registers on. > > >=20 > > > I won't pretend to understand the code, but I did > > > reproduce the problem with 881 by itself and with > > > 889 with 881 reverted. > >=20 > > I can't explain that from reading the code. It looks like a=20 > > no-op to me > > unless the new function bus_register_notifier() is called. > >=20 > > >> 2. Changeset 882 depends on 881. If you revert just 881 then > > >> the tree will not build. > > >=20 > > > This doesn't appear to be the case for me, though > > > I'm certainly willing to believe there's something > > > wrong with my process: > >=20 > > Actually I missed that the dependent code is only built if > > CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got=20 > > one or both > > disabled and hence 882 doesn't break without 881 in your case. > >=20 > > -- Keir > >=20 > >=20 > >