From: Roland Dreier <roland@topspin.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: jgarzik@pobox.com, linux-net@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: drivers/net/at1700.c: at1700_probe1: array overflow
Date: Fri, 25 Mar 2005 10:42:11 -0800 [thread overview]
Message-ID: <528y4b7ekc.fsf@topspin.com> (raw)
In-Reply-To: <20050325181836.GB3153@stusta.de> (Adrian Bunk's message of "Fri, 25 Mar 2005 19:18:36 +0100")
Adrian> This can result in indexing in an array with 8 entries the
Adrian> 10th entry.
Well, not really, since the first 8 entries of the array have every
3-bit pattern. So pos3 & 0x07 will always match one of them.
I agree it would be cleaner to make the loop only go up to 7 though.
- R.
next prev parent reply other threads:[~2005-03-25 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 18:18 drivers/net/at1700.c: at1700_probe1: array overflow Adrian Bunk
2005-03-25 18:42 ` Roland Dreier [this message]
2005-03-25 20:38 ` Adrian Bunk
2005-03-30 0:49 ` null
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528y4b7ekc.fsf@topspin.com \
--to=roland@topspin.com \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.