Re: [Qemu-devel] [PATCH 1.7 0/2] PPC: Fix BookE timer performance regression

[Stefan Weil <sw@weilnetz.de>]

Am 23.11.2013 04:53, schrieb Alexander Graf:
> Thanks to the new timer infrastructure we are now able to trigger timer events
> and ridiculous granularities in sub-microsecond orders.
>
> However, the BookE targets were quite unhappy about that change, showing up
> to x10 slowdown on a simple Linux guest bootup test.
>
> This patch set makes the constant timer facilities in BookE more lazy and less
> fine grained than they could be. That way we're at least as good as we were in
> QEMU 1.6.
>
> Alexander Graf (2):
>   PPC: Make BookE FIT/WDT timers more lazy
>   PPC: BookE: Make FIT/WDT timers at best millisecond grained
>
>  hw/ppc/ppc_booke.c | 49 ++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 44 insertions(+), 5 deletions(-)

Good morning Alexander,

I have two small remarks:

Patch 1: Could you please use 'QemuTimer' instead of 'struct QEMUTimer'
in the modified lines of code?

Patch 2: Milliseconds instead of microseconds (commit message and code
comment)?

Cheers,
Stefan