All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Schiffer <mschiffer@universe-factory.net>
To: Steffen Klassert <steffen.klassert@secunet.com>,
	David Miller <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] xfrm: Fix null pointer dereference when decoding sessions
Date: Sun, 24 Nov 2013 15:27:58 +0100	[thread overview]
Message-ID: <52920CEE.2040407@universe-factory.net> (raw)
In-Reply-To: <1383294107-7509-4-git-send-email-steffen.klassert@secunet.com>

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On 11/01/2013 09:21 AM, Steffen Klassert wrote:
> On some codepaths the skb does not have a dst entry
> when xfrm_decode_session() is called. So check for
> a valid skb_dst() before dereferencing the device
> interface index. We use 0 as the device index if
> there is no valid skb_dst(), or at reverse decoding
> we use skb_iif as device interface index.
> 
> Bug was introduced with git commit bafd4bd4dc
> ("xfrm: Decode sessions with output interface.").
> 
> Reported-by: Meelis Roos <mroos@linux.ee>
> Tested-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

Please queue this for 3.12-stable, I've seen this bug trigger a panic
when heavily using Bittorrent (screenshot:
http://i.imgur.com/OIKVccM.jpg )

Thanks,
Matthias


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2013-11-24 14:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01  8:21 pull request (net): ipsec 2013-11-01 Steffen Klassert
2013-11-01  8:21 ` [PATCH 1/3] xfrm: prevent ipcomp scratch buffer race condition Steffen Klassert
2013-11-01  8:21 ` [PATCH 2/3] xfrm: Increase the garbage collector threshold Steffen Klassert
2013-12-10 14:38   ` Maxime Bizon
2013-12-13 10:12     ` Steffen Klassert
2013-12-13 16:13       ` Maxime Bizon
2013-12-16 11:51         ` Steffen Klassert
2013-12-16 14:29           ` Maxime Bizon
2013-11-01  8:21 ` [PATCH 3/3] xfrm: Fix null pointer dereference when decoding sessions Steffen Klassert
2013-11-24 14:27   ` Matthias Schiffer [this message]
2013-12-01  4:19     ` Matthias Schiffer
2013-12-02  1:35       ` David Miller
2013-12-03  9:56         ` Steffen Klassert
2013-12-03 10:37           ` Wolfgang Walter
2013-12-03 10:41             ` Hannes Frederic Sowa
2013-12-05 21:35           ` David Miller
2013-11-02  5:22 ` pull request (net): ipsec 2013-11-01 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52920CEE.2040407@universe-factory.net \
    --to=mschiffer@universe-factory.net \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.