From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51554)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VkbOv-0005tq-SS
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 10:15:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VkbOq-0003Kr-4Q
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 10:15:09 -0500
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=55099
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VkbOp-0003Hv-Ux
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 10:15:04 -0500
Message-ID: <529217EA.1000302@weilnetz.de>
Date: Sun, 24 Nov 2013 16:14:50 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <20131124095210.GA30741@redhat.com>
In-Reply-To: <20131124095210.GA30741@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 1.7] configure: make --iasl option
 actually work
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <rth@twiddle.net>

Am 24.11.2013 10:52, schrieb Michael S. Tsirkin:
> --iasl option was added to CC option parsing section by mistake,
> it's not effective there and attempts to use cause
> an 'unknown option' error.
>
> Fix this up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f6d5ccd..0592ba7 100755
> --- a/configure
> +++ b/configure
> @@ -272,8 +272,6 @@ for opt do
>    ;;
>    --cxx=*) CXX="$optarg"
>    ;;
> -  --iasl=*) iasl="$optarg"
> -  ;;
>    --source-path=*) source_path="$optarg"
>    ;;
>    --cpu=*) cpu="$optarg"
> @@ -649,6 +647,8 @@ for opt do
>    ;;
>    --cxx=*)
>    ;;
> +  --iasl=*) iasl="$optarg"
> +  ;;
>    --objcc=*) objcc="$optarg"
>    ;;
>    --make=*) make="$optarg"

Reviewed-by: Stefan Weil <sw@weilnetz.de>

This is a trivial bug fix, so maybe it should be committed for QEMU 1.7.
Therefore I changed the subject of the e-mail to include 'for 1.7'.

Regards,
Stefan