From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH 17/17] firewire-lib: Add quirks for
	Fireworks chipset
Date: Mon, 25 Nov 2013 12:13:20 +0900
Message-ID: <5292C050.2010900@sakamocchi.jp>
References: <1385186884-8259-1-git-send-email-o-takashi@sakamocchi.jp>
 <1385186884-8259-18-git-send-email-o-takashi@sakamocchi.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp301.phy.lolipop.jp (smtp301.phy.lolipop.jp [210.157.22.84])
 by alsa0.perex.cz (Postfix) with ESMTP id D463D261A28
 for <alsa-devel@alsa-project.org>; Mon, 25 Nov 2013 04:13:24 +0100 (CET)
In-Reply-To: <1385186884-8259-18-git-send-email-o-takashi@sakamocchi.jp>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: clemens@ladisch.de
Cc: alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net, ffado-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

Hi,

I forgot to add this comment about Fireworks quirk.

====
3. This module handle transmitted packets with both TAG0 and TAG1

In IEC 61883-1, each common isochronous packet (CIP) has 'tag' field in 
its packet header. The value is generally 0x01 (CIP header is included = 
TAG1). But Fireworks in IEC 61883-1/6 compliant mode transmits 'no data' 
packet with 0x00 (No CIP header is included = TAG0) but the packet 
includes CIP structure. For duplex streams synchronization, this packets 
must be handled.

Current firewire-lib supports packet with TAG1. This commit makes 
firewire-lib to support both TAG0 and TAG1 for this quirk.

When handling CIP packet with invalid header, this module already output 
'Invalid CIP header for AMDTP' log and continue to process.

(I note this 'no data' packet is out of specification because it 
includes no dummy data. In IEC 61883-6, 'no data' packet is generated by 
two ways. One is empty CIP packet defined in IEC 61883-1. Another is 
'special non-empty packet' defined in IEC 61883-6. Fireworks uses 
strange combination of them.)
====

Regards

Takashi Sakamoto
o-takashi@sakamocchi.jp