From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lokesh Vutla <lokeshvutla@ti.com>
Date: Mon, 25 Nov 2013 10:16:45 +0530
Subject: [U-Boot] [PATCH V2 05/14] ARM: AM43XX: board: add support for
 reading onboard EEPROM
In-Reply-To: <CANacCWyQ4biV9Z9HDb3rrHyB9nKuuMwi8L2W3EDx2GzByvZhQQ@mail.gmail.com>
References: <1385014699-7257-1-git-send-email-lokeshvutla@ti.com>
	<1385014699-7257-6-git-send-email-lokeshvutla@ti.com>
	<CANacCWyQ4biV9Z9HDb3rrHyB9nKuuMwi8L2W3EDx2GzByvZhQQ@mail.gmail.com>
Message-ID: <5292D635.3020905@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday 22 November 2013 01:56 AM, Vaibhav Bedia wrote:
> On Thu, Nov 21, 2013 at 1:18 AM, Lokesh Vutla <lokeshvutla@ti.com> wrote:
> [...]
>>  #define NON_SECURE_SRAM_START  0x402F0400
>>  #define NON_SECURE_SRAM_END    0x40340000
>>  #define SRAM_SCRATCH_SPACE_ADDR        0x4033C000
>> +#define AM4372_BOARD_NAME_START        SRAM_SCRATCH_SPACE_ADDR
>> +#define AM4372_BOARD_NAME_END  SRAM_SCRATCH_SPACE_ADDR + 0xC
> 
> Why do you need to keep the struct address hardcoded like this?
FYI, this is not struct address. This is the place where where I am storing board name.
This helps in detecting the board.
It ll be good to understand the code properly and comment.
> 
> [...]
>> +static inline int board_is_eposevm(void)
>> +{
>> +       return !strncmp(am43xx_board_name, "AM43EPOS", HDR_NAME_LEN);
>> +}
>> +
>> +static inline int board_is_gpevm(void)
>> +{
>> +       return !strncmp(am43xx_board_name, "AM43__GP", HDR_NAME_LEN);
>> +}
>> +
> 
> Looks like you got the EEPROM content updated ;)
There is nothing updated. This is what I have used previously.
Please recollect your comments properly.

Thanks and regards,
Lokesh
> 
> Regards,
> Vaibhav
>