From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VksDq-0008JO-4N for qemu-devel@nongnu.org; Mon, 25 Nov 2013 04:12:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VksDj-0000nq-E1 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 04:12:50 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:39364 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VksDj-0000nc-48 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 04:12:43 -0500 Message-ID: <5293149F.8000408@kamp.de> Date: Mon, 25 Nov 2013 10:13:03 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1385124001-3576-1-git-send-email-pbonzini@redhat.com> <1385124001-3576-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1385124001-3576-5-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 04/19] block: add bdrv_aio_write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com On 22.11.2013 13:39, Paolo Bonzini wrote: > This will be used by the SCSI layer. > > Signed-off-by: Paolo Bonzini > --- > block.c | 11 +++++++++++ > include/block/block.h | 3 +++ > trace-events | 1 + > 3 files changed, 15 insertions(+) > > diff --git a/block.c b/block.c > index cb07e57..f9674d9 100644 > --- a/block.c > +++ b/block.c > @@ -3670,6 +3670,17 @@ BlockDriverAIOCB *bdrv_aio_writev(BlockDriverState *bs, int64_t sector_num, > cb, opaque, true); > } > > +BlockDriverAIOCB *bdrv_aio_write_zeroes(BlockDriverState *bs, > + int64_t sector_num, int nb_sectors, BdrvRequestFlags flags, > + BlockDriverCompletionFunc *cb, void *opaque) > +{ > + trace_bdrv_aio_write_zeroes(bs, sector_num, nb_sectors, flags, opaque); > + > + return bdrv_co_aio_rw_vector(bs, sector_num, NULL, nb_sectors, > + BDRV_REQ_ZERO_WRITE | flags, > + cb, opaque, true); > +} > + > > typedef struct MultiwriteCB { > int error; > diff --git a/include/block/block.h b/include/block/block.h > index 703d875..4967ed2 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -216,6 +216,9 @@ int bdrv_write(BlockDriverState *bs, int64_t sector_num, > const uint8_t *buf, int nb_sectors); > int bdrv_write_zeroes(BlockDriverState *bs, int64_t sector_num, > int nb_sectors, BdrvRequestFlags flags); > +BlockDriverAIOCB *bdrv_aio_write_zeroes(BlockDriverState *bs, int64_t sector_num, > + int nb_sectors, BdrvRequestFlags flags, > + BlockDriverCompletionFunc *cb, void *opaque); > int bdrv_make_zero(BlockDriverState *bs, BdrvRequestFlags flags); > int bdrv_writev(BlockDriverState *bs, int64_t sector_num, QEMUIOVector *qiov); > int bdrv_pread(BlockDriverState *bs, int64_t offset, > diff --git a/trace-events b/trace-events > index f159ac9..d318d6f 100644 > --- a/trace-events > +++ b/trace-events > @@ -60,6 +60,7 @@ bdrv_aio_discard(void *bs, int64_t sector_num, int nb_sectors, void *opaque) "bs > bdrv_aio_flush(void *bs, void *opaque) "bs %p opaque %p" > bdrv_aio_readv(void *bs, int64_t sector_num, int nb_sectors, void *opaque) "bs %p sector_num %"PRId64" nb_sectors %d opaque %p" > bdrv_aio_writev(void *bs, int64_t sector_num, int nb_sectors, void *opaque) "bs %p sector_num %"PRId64" nb_sectors %d opaque %p" > +bdrv_aio_write_zeroes(void *bs, int64_t sector_num, int nb_sectors, int flags, void *opaque) "bs %p sector_num %"PRId64" nb_sectors %d flags %#x opaque %p" > bdrv_lock_medium(void *bs, bool locked) "bs %p locked %d" > bdrv_co_readv(void *bs, int64_t sector_num, int nb_sector) "bs %p sector_num %"PRId64" nb_sectors %d" > bdrv_co_copy_on_readv(void *bs, int64_t sector_num, int nb_sector) "bs %p sector_num %"PRId64" nb_sectors %d" Reviewed-by: Peter Lieven