From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>, linville@tuxdriver.com
Cc: brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmsmac: remove dependency on CRC8 and CRC_CCITT
Date: Mon, 25 Nov 2013 10:25:06 +0100 [thread overview]
Message-ID: <52931772.30407@broadcom.com> (raw)
In-Reply-To: <1385327021-26851-1-git-send-email-hauke@hauke-m.de>
On 11/24/2013 10:03 PM, Hauke Mehrtens wrote:
> There is no code in brcmsmac that uses a function from CRC8 or
> CRC_CCITT any more. Building brcmsmac with these two disabled works
> without any problems. This was probably only used by the bus code which
> was replaced by bcma some time ago.
True. These could be removed when using bcma. Thanks for cleaning that up.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/wireless/brcm80211/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig
> index b00a7e9..ce0add3 100644
> --- a/drivers/net/wireless/brcm80211/Kconfig
> +++ b/drivers/net/wireless/brcm80211/Kconfig
> @@ -7,8 +7,6 @@ config BRCMSMAC
> depends on BCMA
> select BRCMUTIL
> select FW_LOADER
> - select CRC_CCITT
> - select CRC8
> select CORDIC
> ---help---
> This module adds support for PCIe wireless adapters based on Broadcom
>
prev parent reply other threads:[~2013-11-25 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 21:03 [PATCH] brcmsmac: remove dependency on CRC8 and CRC_CCITT Hauke Mehrtens
2013-11-25 9:25 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52931772.30407@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.