From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vksrl-0006yg-GH
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 04:54:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vksrf-0006zP-GU
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 04:54:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42532)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vksrf-0006zH-8R
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 04:53:59 -0500
Message-ID: <52931E28.8010800@redhat.com>
Date: Mon, 25 Nov 2013 10:53:44 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20131124093704.GA26763@redhat.com> <5291DD42.1050603@weilnetz.de>
In-Reply-To: <5291DD42.1050603@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in
	config-host.mak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <rth@twiddle.net>

Il 24/11/2013 12:04, Stefan Weil ha scritto:
> Do we really need this? It only makes git bisect iterations from
> versions after 2013-11-19 to versions before that date easier. If a
> typical git bisect needs 10 steps, then in the worst cast 5 of them
> won't automatically run configure. This is normally not a big problem
> because there is already a configuration, and many changes of file
> configure don't change that configuration.
> 
> It's always possible to run configure explicitly at each step of the
> bisection process, so in case of doubt there is an easy fall-back
> solution. Before I introduced automatic reconfiguration, calling
> configure + make was normal for git bisect.
> 
> I'd prefer to avoid code like this patch which is only marginally useful
> in a very specific development use case. People who can run git bisect
> will be able to help themselves if they really get a problem without the
> patch.

I think anything that makes it easier for users to do bisections instead
of us, and anything that makes it easier to script bisections ("git
bisect run"), is valuable.

Thanks Michael, patch

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

for 1.7 too.

Paolo